The infamous CLA check is back

[ederag]

@elbenfreund, it's back

It's most probably a mistake, as you well know this code is pure GPL,
and can never be re-licensed otherwise.

Please remove it, that scares contributors off,
and increases the risk of someone else putting a CLA on this by mistake.

[ederag]

After 859a89e, the check disappeared from #573.
But it is still there for the other PR.

[matthijskooijman]

Looking at recent pull requests, I see no CLA checks anymore, so I think this is now properly disabled. I'll close this, we can reopen when this turns out to be false.

[ederag]

A message has to be given in all PR with this wrong check then.
I'll do this, to lift any ambiguity.

[matthijskooijman]

I'd rather just delete the comments, let me do that.

[matthijskooijman]

Seems there was just one CLA comment left, I deleted it. I also deleted @ederag's followup comments since they referred already deleted CLA comments, which probably only adds confusion.

[ederag]

More than 15 min later, the checks still appear.

Don't you dare delete any of my comments again without prior discussion.
That's disrespectful.

[matthijskooijman]

Ah, I was looking at the CLA assistant comments, but there are indeed still (or again) pending checks. I see this is only the case on some PRs and not new ones, so that probably means that the checks are properly disabled now, but the existing ones still linger. Not sure if they can be removed, maybe @ederag can.

As for deleting comments, sorry for that. It seemed better to delete the CLA comments, and with that also your comment since it would otherwise not make sense. When I found no further CLA comments, I thought you were being overzealous in adding comments everywhere, but it seems I just missed the pending check.

In any case, I reposted some comments, and posted one additional one, so I think all pending checks have not been covered and this can be closed again. Agreed?