Crash when using smart routing

[deltakosh]

Hey!

I've got this error when using smart routing:

Uncaught TypeError: Cannot set property 'g' of undefined
    at JPFNeverMoveDiagonally.JumpPointFinderBase.findPath (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:61210)
    at PathFinding.calculateDirectPath (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:61210)
    at DefaultLinkWidget.render (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:61210)
    at finishClassComponent (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:52291)
    at updateClassComponent (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:52254)
    at beginWork (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:53072)
    at performUnitOfWork (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:55810)
    at workLoop (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:55850)
    at renderRoot (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:55936)
    at performWorkOnRoot (:1338/.temp/localDevUMD/nodeEditor/babylon.nodeEditor.js:56827)

If I turn smart routing off, it works flawlessly

Here is our setup (with smart routing off):
https://github.com/BabylonJS/Babylon.js/blob/master/nodeEditor/src/graphEditor.tsx#L528

Thanks a lot!

[dylanvorster]

Oh wow, its now in a game engine O_O I am busy reworking the entire smart routing system as we speak. The new system introduces smart routing as a new type of Link. I hope to have something out in the next few days, and this might solve your issue. If not, I'm really interested in working with you to help make this a success in your project.

[dylanvorster]

to follow the progress, head on over to https://gitter.im/projectstorm/react-diagrams

[dylanvorster]

Also the new structure of the project: https://github.com/projectstorm/react-diagrams/tree/lerna (you will be interested in the lib-routing folder)

[deltakosh]

Man we love your library:)

[deltakosh]

What should I do to switch to the new project? (using 5.2.1 for now)
Your tool will be a central piece of our 4.1 release as it will fuel our Node Material system :)

So glad we can work together

[dylanvorster]

Definitely getting some blender comp-pipeline and Unreal-engine vibes in that screenshot. Ill let you know as soon I have something available

[dylanvorster]

Im also busy fixing the link issue (the one where it doesnt respect horizonal mode)

[deltakosh]

Clearly:) feel free to ping me at david@catuhe.com if you want to chat!

[dylanvorster]

New fixes rolling out soon:

You can specify the alignment of a port (top, left, bottom, right etc..)

[deltakosh]

Exactly what we need!!!

[dylanvorster]

update from my side:

• thanks to lots of componentShouldUpdate improvements, the large performance demo goes down from 140ms rendering times to 3 to 10 ms rendering times.
• you no longer need to call recalculatePortCoords (method is removed)
• there is no longer a double render cycle on initial render, the links now efficiently track their target ports on initial renders and wait for them to report initial dimensions.

[dylanvorster]

if you check out the lerna branch, run yarn in the root and then head to the lib-demo-gallery you can run yarn start and then you should get the new demos. Ive been giving this some thought, and I wouldn't mind getting involved in upgrading your current implementation in Babylone.js when this releases

[deltakosh]

Oh man I did not dare asking but we will be honored to get your help on using your lib the best possible way

[dylanvorster]

So version 6 [Beta] is now out, and I would love to get your thoughts on the new system. I also have smart routing working again (the original issue in this ticket). Let me know!