Migrate to golangci-lint v2.

Signed-off-by: SuperQ <[email protected]>

Author: SuperQ

.golangci.yml

@@ -1,20 +1,26 @@
----
+version: "2"
 linters:
   enable:
     - misspell
     - revive
     - sloglint
-
-linters-settings:
-  errcheck:
-    exclude-functions:
-      # Don't flag lines such as "io.Copy(io.Discard, resp.Body)".
-      - io.Copy
-      # Used in HTTP handlers, any error is handled by the server itself.
-      - (net/http.ResponseWriter).Write
-  revive:
-    rules:
-      # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#unused-parameter
-      - name: unused-parameter
-        severity: warning
-        disabled: true
+  settings:
+    errcheck:
+      exclude-functions:
+        - io.Copy
+        - (net/http.ResponseWriter).Write
+    revive:
+      rules:
+        - name: unused-parameter
+          severity: warning
+          disabled: true
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+formatters:
+  exclusions:
+    generated: lax

cmd/proxy/coordinator.go

@@ -115,7 +115,7 @@ func (c *Coordinator) DoScrape(ctx context.Context, r *http.Request) (*http.Resp
 	r.Header.Add("Id", id)
 	select {
 	case <-ctx.Done():
-		return nil, fmt.Errorf("Timeout reached for %q: %s", r.URL.String(), ctx.Err())
+		return nil, fmt.Errorf("timeout reached for %q: %s", r.URL.String(), ctx.Err())
 	case c.getRequestChannel(r.URL.Hostname()) <- r:
 	}
 

cmd/proxy/main.go

@@ -145,7 +145,7 @@ func (h *httpHandler) handlePoll(w http.ResponseWriter, r *http.Request) {
 	request, err := h.coordinator.WaitForScrapeInstruction(strings.TrimSpace(string(fqdn)))
 	if err != nil {
 		h.logger.Info("Error WaitForScrapeInstruction:", "err", err)
-		http.Error(w, fmt.Sprintf("Error WaitForScrapeInstruction: %s", err.Error()), 408)
+		http.Error(w, fmt.Sprintf("Error WaitForScrapeInstruction: %s", err.Error()), http.StatusRequestTimeout)
 		return
 	}
 	//nolint:errcheck // https://github.com/prometheus-community/PushProx/issues/111