@@ -36,29 +36,6 @@ GO_VERSION ?= $(shell $(GO) version)
36
36
GO_VERSION_NUMBER ?= $(word 3, $(GO_VERSION))
37
37
PRE_GO_111 ?= $(shell echo $(GO_VERSION_NUMBER) | grep -E 'go1\.(10|[0-9])\.')
38
38
39
- GOVENDOR :=
40
- GO111MODULE :=
41
- ifeq (, $(PRE_GO_111))
42
- ifneq (,$(wildcard go.mod))
43
- # Enforce Go modules support just in case the directory is inside GOPATH (and for Travis CI).
44
- GO111MODULE := on
45
-
46
- ifneq (,$(wildcard vendor))
47
- # Always use the local vendor/ directory to satisfy the dependencies.
48
- GOOPTS := $(GOOPTS) -mod=vendor
49
- endif
50
- endif
51
- else
52
- ifneq (,$(wildcard go.mod))
53
- ifneq (,$(wildcard vendor))
54
- $(warning This repository requires Go >= 1.11 because of Go modules)
55
- $(warning Some recipes may not work as expected as the current Go runtime is '$(GO_VERSION_NUMBER)')
56
- endif
57
- else
58
- # This repository isn't using Go modules (yet).
59
- GOVENDOR := $(FIRST_GOPATH)/bin/govendor
60
- endif
61
- endif
62
39
PROMU := $(FIRST_GOPATH)/bin/promu
63
40
pkgs = ./...
64
41
@@ -78,19 +55,22 @@ ifneq ($(shell which gotestsum),)
78
55
endif
79
56
endif
80
57
81
- PROMU_VERSION ?= 0.12 .0
58
+ PROMU_VERSION ?= 0.13 .0
82
59
PROMU_URL := https://github.com/prometheus/promu/releases/download/v$(PROMU_VERSION)/promu-$(PROMU_VERSION).$(GO_BUILD_PLATFORM).tar.gz
83
60
61
+ SKIP_GOLANGCI_LINT :=
84
62
GOLANGCI_LINT :=
85
63
GOLANGCI_LINT_OPTS ?=
86
- GOLANGCI_LINT_VERSION ?= v1.42 .0
64
+ GOLANGCI_LINT_VERSION ?= v1.49 .0
87
65
# golangci-lint only supports linux, darwin and windows platforms on i386/amd64.
88
66
# windows isn't included here because of the path separator being different.
89
67
ifeq ($(GOHOSTOS),$(filter $(GOHOSTOS),linux darwin))
90
68
ifeq ($(GOHOSTARCH),$(filter $(GOHOSTARCH),amd64 i386))
91
69
# If we're in CI and there is an Actions file, that means the linter
92
70
# is being run in Actions, so we don't need to run it here.
93
- ifeq (,$(CIRCLE_JOB))
71
+ ifneq (,$(SKIP_GOLANGCI_LINT))
72
+ GOLANGCI_LINT :=
73
+ else ifeq (,$(CIRCLE_JOB))
94
74
GOLANGCI_LINT := $(FIRST_GOPATH)/bin/golangci-lint
95
75
else ifeq (,$(wildcard .github/workflows/golangci-lint.yml))
96
76
GOLANGCI_LINT := $(FIRST_GOPATH)/bin/golangci-lint
@@ -150,58 +130,47 @@ common-check_license:
150
130
.PHONY: common-deps
151
131
common-deps:
152
132
@echo ">> getting dependencies"
153
- ifdef GO111MODULE
154
- GO111MODULE=$(GO111MODULE) $(GO) mod download
155
- else
156
- $(GO) get $(GOOPTS) -t ./...
157
- endif
133
+ $(GO) mod download
158
134
159
135
.PHONY: update-go-deps
160
136
update-go-deps:
161
137
@echo ">> updating Go dependencies"
162
138
@for m in $$($(GO) list -mod=readonly -m -f '{{ if and (not .Indirect) (not .Main)}}{{.Path}}{{end}}' all); do \
163
- $(GO) get $$m; \
139
+ $(GO) get -d $$m; \
164
140
done
165
- GO111MODULE=$(GO111MODULE) $(GO) mod tidy
166
- ifneq (,$(wildcard vendor))
167
- GO111MODULE=$(GO111MODULE) $(GO) mod vendor
168
- endif
141
+ $(GO) mod tidy
169
142
170
143
.PHONY: common-test-short
171
144
common-test-short: $(GOTEST_DIR)
172
145
@echo ">> running short tests"
173
- GO111MODULE=$(GO111MODULE) $(GOTEST) -short $(GOOPTS) $(pkgs)
146
+ $(GOTEST) -short $(GOOPTS) $(pkgs)
174
147
175
148
.PHONY: common-test
176
149
common-test: $(GOTEST_DIR)
177
150
@echo ">> running all tests"
178
- GO111MODULE=$(GO111MODULE) $(GOTEST) $(test-flags) $(GOOPTS) $(pkgs)
151
+ $(GOTEST) $(test-flags) $(GOOPTS) $(pkgs)
179
152
180
153
$(GOTEST_DIR):
181
154
@mkdir -p $@
182
155
183
156
.PHONY: common-format
184
157
common-format:
185
158
@echo ">> formatting code"
186
- GO111MODULE=$(GO111MODULE) $(GO) fmt $(pkgs)
159
+ $(GO) fmt $(pkgs)
187
160
188
161
.PHONY: common-vet
189
162
common-vet:
190
163
@echo ">> vetting code"
191
- GO111MODULE=$(GO111MODULE) $(GO) vet $(GOOPTS) $(pkgs)
164
+ $(GO) vet $(GOOPTS) $(pkgs)
192
165
193
166
.PHONY: common-lint
194
167
common-lint: $(GOLANGCI_LINT)
195
168
ifdef GOLANGCI_LINT
196
169
@echo ">> running golangci-lint"
197
- ifdef GO111MODULE
198
170
# 'go list' needs to be executed before staticcheck to prepopulate the modules cache.
199
171
# Otherwise staticcheck might fail randomly for some reason not yet explained.
200
- GO111MODULE=$(GO111MODULE) $(GO) list -e -compiled -test=true -export=false -deps=true -find=false -tags= -- ./... > /dev/null
201
- GO111MODULE=$(GO111MODULE) $(GOLANGCI_LINT) run $(GOLANGCI_LINT_OPTS) $(pkgs)
202
- else
203
- $(GOLANGCI_LINT) run $(pkgs)
204
- endif
172
+ $(GO) list -e -compiled -test=true -export=false -deps=true -find=false -tags= -- ./... > /dev/null
173
+ $(GOLANGCI_LINT) run $(GOLANGCI_LINT_OPTS) $(pkgs)
205
174
endif
206
175
207
176
.PHONY: common-yamllint
@@ -218,28 +187,15 @@ endif
218
187
common-staticcheck: lint
219
188
220
189
.PHONY: common-unused
221
- common-unused: $(GOVENDOR)
222
- ifdef GOVENDOR
223
- @echo ">> running check for unused packages"
224
- @$(GOVENDOR) list +unused | grep . && exit 1 || echo 'No unused packages'
225
- else
226
- ifdef GO111MODULE
190
+ common-unused:
227
191
@echo ">> running check for unused/missing packages in go.mod"
228
- GO111MODULE=$(GO111MODULE) $(GO) mod tidy
229
- ifeq (,$(wildcard vendor))
192
+ $(GO) mod tidy
230
193
@git diff --exit-code -- go.sum go.mod
231
- else
232
- @echo ">> running check for unused packages in vendor/"
233
- GO111MODULE=$(GO111MODULE) $(GO) mod vendor
234
- @git diff --exit-code -- go.sum go.mod vendor/
235
- endif
236
- endif
237
- endif
238
194
239
195
.PHONY: common-build
240
196
common-build: promu
241
197
@echo ">> building binaries"
242
- GO111MODULE=$(GO111MODULE) $(PROMU) build --prefix $(PREFIX) $(PROMU_BINARIES)
198
+ $(PROMU) build --prefix $(PREFIX) $(PROMU_BINARIES)
243
199
244
200
.PHONY: common-tarball
245
201
common-tarball: promu
@@ -295,12 +251,6 @@ $(GOLANGCI_LINT):
295
251
| sh -s -- -b $(FIRST_GOPATH)/bin $(GOLANGCI_LINT_VERSION)
296
252
endif
297
253
298
- ifdef GOVENDOR
299
- .PHONY: $(GOVENDOR)
300
- $(GOVENDOR):
301
- GOOS= GOARCH= $(GO) get -u github.com/kardianos/govendor
302
- endif
303
-
304
254
.PHONY: precheck
305
255
precheck::
306
256
0 commit comments