Skip to content

Surface failed metric collections to the collector #97

Open
@isker

Description

@isker

We swallow errors making ECS task metadata API requests here and here. There is actually a way to surface errors to the caller: NewInvalidMetric.

I think we should use it so that errors are surfaced at write time, as in promhttp. The ECS APIs are supposed to be infallible, so the default behavior of serving an HTTP 500 on the /metrics request probably makes sense for everyone in all situations, though we could add a flag to control the behavior.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions