Better metric names and description

Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>

Author: Philldomd

README.md

@@ -38,7 +38,7 @@ Supported metrics right now as follows.
 Global:
 
  * _Network/Dns/Latency_
-   * `fortigate_network_dns_latency`
+   * `fortigate_network_dns_latency_`
    * `fortigate_network_dns_latest_update`
  * _System/SensorInfo_
    * `fortigate_sensor_fan_rpm`

pkg/probe/network_dns_latency.go

@@ -23,13 +23,13 @@ import (
 func probeNetworkDnsLatency(c http.FortiHTTP, meta *TargetMetadata) ([]prometheus.Metric, bool) {
 	var (
 		dnsLatency = prometheus.NewDesc(
-			"fortigate_network_dns_latency",
+			"fortigate_network_dns_latency_seconds",
 			"Network dns latency",
 			[]string{"service", "ip"}, nil,
 		)
 		dnsLastUpdate = prometheus.NewDesc(
 			"fortigate_network_dns_latest_update",
-			"Network dns last update",
+			"Network dns last record update",
 			[]string{"service", "ip"}, nil,
 		)
 	)
@@ -52,7 +52,7 @@ func probeNetworkDnsLatency(c http.FortiHTTP, meta *TargetMetadata) ([]prometheu
 	}
 	m := []prometheus.Metric{}
 	for _, r := range res.Results {
-		m = append(m, prometheus.MustNewConstMetric(dnsLatency, prometheus.GaugeValue, r.Latency, r.Service, r.Ip))
+		m = append(m, prometheus.MustNewConstMetric(dnsLatency, prometheus.GaugeValue, r.Latency * 0.001, r.Service, r.Ip))
 		m = append(m, prometheus.MustNewConstMetric(dnsLastUpdate, prometheus.GaugeValue, r.LastUpdate, r.Service, r.Ip))
 	}
 

pkg/probe/network_dns_latency_test.go

@@ -29,10 +29,10 @@ func TestNetworkDnsLatency(t *testing.T) {
 	}
 
 	em := `
-	# HELP fortigate_network_dns_latency Network dns latency
-	# TYPE fortigate_network_dns_latency gauge
-	fortigate_network_dns_latency{ip="8.8.8.8",service="dns_server"} 10
-	# HELP fortigate_network_dns_latest_update Network dns last update
+	# HELP fortigate_network_dns_latency_seconds Network dns latency
+	# TYPE fortigate_network_dns_latency_seconds gauge
+	fortigate_network_dns_latency_seconds{ip="8.8.8.8",service="dns_server"} 0.01
+	# HELP fortigate_network_dns_latest_update Network dns last record update
 	# TYPE fortigate_network_dns_latest_update gauge
 	fortigate_network_dns_latest_update{ip="8.8.8.8",service="dns_server"} 1040
 	`