feat: added ARP Table informatio and corresponding testcase - #259
feat: added ARP Table informatio and corresponding testcase#259FriendlyButFire wants to merge 1 commit into
Conversation
bluecmd
left a comment
There was a problem hiding this comment.
This metric will have to be disabled by default if you really really want it in the current state. The metric dimensions are extremely large (any IP * any MAC * any interface).
Are you sure this is what you want? The total amount of MACs per interface isn't enough?
| * _System/Fortimanager/Status_ | ||
| * `fortigate_fortimanager_connection_status` | ||
| * `fortigate_fortimanager_registration_status` | ||
| * `fortigate_ippool_total_items` |
There was a problem hiding this comment.
yea, sorry, don't really know if to remove I have to recommit
Being disabled by default is fine for me, that's the use case I'm aiming for, I just wanted to share the implementation of it to everyone |
Files that have been added:
./pkg/probe/system_arp.go
./pkg/probe/system_arp_test.go
./pkg/probe/testdata/arp.jsonnet
Files that have been changed:
./pkg/probe/probe.go
./README.md
Tested on FortiGate KVM with FortiOS Version v7.0.5