[prometheus-pushgateway] remove default labels from persistent volume (#5280)

* [prometheus-pushgateway] fix: remove default labels from persistent volume

Signed-off-by: sipr-invivo <160140834+sipr-invivo@users.noreply.github.com>

* Bump chart version

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

* Add upgrade note

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

---------

Signed-off-by: sipr-invivo <160140834+sipr-invivo@users.noreply.github.com>
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com>

Author: sipr-invivo

charts/prometheus-pushgateway/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: "v1.11.0"
 description: A Helm chart for prometheus pushgateway
 name: prometheus-pushgateway
-version: 2.17.0
+version: 3.0.0
 home: https://github.com/prometheus/pushgateway
 sources:
   - https://github.com/prometheus/pushgateway

charts/prometheus-pushgateway/README.md

@@ -41,6 +41,19 @@ helm upgrade [RELEASE_NAME] prometheus-community/prometheus-pushgateway --instal
 
 _See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documentation._
 
+### To 3.0.0
+
+Previously, as dynamic labels were also set on the statefulset's volume claim template, it was not possible
+to upgrade a chart release in a usual manner whilst using a statefulset and persistence due to the volume claim template's fields being immutable.
+
+This release removes the dynamic labels from the statefulset's volume claim template.
+If you have configured a statefulset with persistent storage,
+please, delete the statefulset before upgrading:
+
+```console
+kubectl delete sts -l app.kubernetes.io/name=prometheus-pushgateway --cascade=orphan
+```
+
 ### To 2.0.0
 
 Chart API version has been upgraded to v2 so Helm 3 is needed from now on.

charts/prometheus-pushgateway/templates/statefulset.yaml

@@ -29,8 +29,10 @@ spec:
         annotations:
           {{- toYaml . | nindent 10 }}
         {{- end }}
+        {{- with .Values.persistentVolumeLabels }}
         labels:
-          {{- include "prometheus-pushgateway.defaultLabels" . | nindent 10 }}
+          {{- toYaml . | nindent 10 }}
+        {{- end }}
         name: storage-volume
       spec:
         accessModes: