Skip to content

[prometheus-postgres-exporter] fix rule rendering, #5508 #5509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[prometheus-postgres-exporter] fix rule rendering, #5508 #5509

wants to merge 2 commits into from

Conversation

fredericve
Copy link

What this PR does / why we need it

Fixes prometheusRule rendering when using alert variables in alert annotations

Which issue this PR fixes

Special notes for your reviewer

@gianrubio , @zanhsieh , @zeritti
Exactly the same thing happened in #2450. The solution there was to remove the tpl function so I suggest doing the same here.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianrubio gianrubio Awaiting requested review from gianrubio gianrubio is a code owner

@zanhsieh zanhsieh Awaiting requested review from zanhsieh zanhsieh is a code owner

@zeritti zeritti Awaiting requested review from zeritti zeritti is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[prometheus-postgres-exporter] unable to use alert variables in prometheusRule entries
2 participants
@fredericve @zanhsieh