Skip to content

[prometheus-redis-exporter] multipleTarget issue #5532

Open
@emily-ganze

Description

@emily-ganze

Describe the bug a clear and concise description of what the bug is.

Hello,

When enabling multipleTarget, the REDIS_ADDR env variable is still defaulted to values.redisAddress and mutlipleTarget is not considered in the deployment template.

deployment template:

          env:
            - name: REDIS_ADDR
            {{- if .Values.redisAddressConfig.enabled }}
              valueFrom:
              {{- if .Values.redisAddressConfig.isSecret }}
                secretKeyRef:
              {{- else }}
                configMapKeyRef:
              {{- end }}
                  name: {{ .Values.redisAddressConfig.source.name }}
                  key: {{ .Values.redisAddressConfig.source.key }}
            {{- else }}
              value: {{ .Values.redisAddress }}
            {{- end }}

default helm values lines 65-66:

# If serviceMonitor.multipleTarget is enabled, this configuration is actually not used
redisAddress: redis://myredis:6379

configured helm yaml:

serviceMonitor:
    enabled: true
    multipleTarget: true
    targets:
    - url: "URL1:6379"
      name: redis1
    - url: "URL2:6379"
      name: redis2

logs:

error msg="Couldn't connect to redis instance (redis://myredis:6379)"

What's your helm version?

version.BuildInfo{Version:"v3.17.1", GitCommit:"980d8ac1939e39138101364400756af2bdee1da5", GitTreeState:"clean", GoVersion:"go1.23.6"}

What's your kubectl version?

Client Version: v1.32.2

Which chart?

prometheus-redis-exporter

What's the chart version?

6.9.0

What happened?

No response

What you expected to happen?

mutlipleTarget is not being honored for the environment variable REDIS_ADDR

How to reproduce it?

enable multipleTarget

Enter the changed values of values.yaml?

serviceMonitor:
enabled: true
multipleTarget: true
targets:
- url: "URL1:6379"
name: redis1
- url: "URL2:6379"
name: redis2

Enter the command that you execute and failing/misfunctioning.

helm install Chart.yaml --values values.yaml

Anything else we need to know?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions