Skip to content

[prometheus] cadvisor/node labeling inconsistent with kube-prometheus-stack and others in the ecosystem #5535

Open
@deepy

Description

@deepy

Describe the bug a clear and concise description of what the bug is.

The job kubernetes-nodes-cadvisor in the prometheus chart sets the instance label to the name of the node, e.g.

container_memory_rss{instance="debian-fish", job="kubernetes-nodes-cadvisor"}

(And does so for kubernetes-nodes as well)

Whereas the same setup in kube-prometheus-stack nets you:

container_memory_rss{node="debian-fish", instance="10.0.0.15:12345"}

This is somewhat confusing and causes issues with projects that rely on prometheus, I think the name of the node should be moved to the node label and instance kept as ip:port
Or at a minimum the node label should be added as well

Currently kubernetes-nodes and kubernetes-nodes-cadvisor are odd in this regard, as the other scrape jobs leaves instance as ip:port

What's your helm version?

v3.17.3

What's your kubectl version?

1.32

Which chart?

prometheus

What's the chart version?

27.8.0

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

No response

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

helm -n promonly install prom prometheus-community/prometheus

Anything else we need to know?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions