Skip to content

Commit 83e7d6e

Browse files
authored
Merge pull request #278 from anthonyeleven/improve-readme
chore: Improve CONTRIBUTING.md and README.md
2 parents 291d010 + deaa5bb commit 83e7d6e

2 files changed

Lines changed: 14 additions & 15 deletions

File tree

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ bug.
2727
1. [Fork the repository][fork].
2828
2. [Create a topic branch][branch].
2929
3. Implement your feature or bug fix.
30-
4. Unlike we did so far, maybe add tests and make sure that they completely
30+
4. When making code changes, ideally add tests and ensure that they completely
3131
cover your changes and potential edge cases.
32-
5. If there are tests now, run `go test`. If your tests fail, revise your code
33-
and tests, and rerun `go test` until they pass.
32+
5. If there are pre-existing tests, run `go test`. If tests fail, revise your code
33+
and tests, and repeat `go test` until they pass.
3434
6. Add documentation for your feature or bug fix in the code, documentation, or
3535
PR/commit message.
3636
7. Commit and push your changes.

README.md

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@ This is an IPMI exporter for [Prometheus][prometheus].
88
[prometheus]: https://prometheus.io "Prometheus homepage"
99

1010
It supports both the regular `/metrics` endpoint, exposing metrics from the
11-
host that the exporter is running on, as well as an `/ipmi` endpoint that
11+
host on which the exporter runs, as well as a `/ipmi` endpoint that
1212
supports IPMI over RMCP, implementing the multi-target exporter pattern. If you
1313
plan to use the latter, please read the guide [Understanding and using the
14-
multi-target exporter pattern][multi-target] to get the general idea about the
15-
configuration.
14+
multi-target exporter pattern][multi-target] for an overview of that paradigm.
1615

1716
[multi-target]: https://prometheus.io/docs/guides/multi-target-exporter/
1817

@@ -32,7 +31,7 @@ For most use-cases, simply download the [the latest release][releases].
3231

3332
[releases]: https://github.com/prometheus-community/ipmi_exporter/releases "IPMI exporter releases on Github"
3433

35-
For Kubernets, you can use the community-maintained [Helm chart][helm].
34+
For Kubernetes, you can use the community-maintained [Helm chart][helm].
3635

3736
[helm]: https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-ipmi-exporter "IPMI exporter Helm chart in the helm-charts Github repo"
3837

@@ -49,9 +48,9 @@ executable:
4948

5049
make
5150

52-
This uses the common prometheus tooling to build and run some tests.
51+
This uses common Prometheus tooling to build the exporter and run tests.
5352

54-
Alternatively, you can use the standard Go tooling, which will install the
53+
Alternatively, you can use standard Go tooling, which will install the
5554
executable in `$GOPATH/bin`:
5655

5756
go install github.com/prometheus-community/ipmi_exporter@latest
@@ -80,7 +79,7 @@ For syntax and a complete list of available parameters, run:
8079

8180
./ipmi_exporter -h
8281

83-
Make sure you have the following tools from the [FreeIPMI][freeipmi] suite
82+
Ensure that the following tools from the [FreeIPMI][freeipmi] suite are
8483
installed:
8584

8685
- `ipmimonitoring`/`ipmi-sensors`
@@ -92,16 +91,16 @@ installed:
9291

9392
When running a container image, make sure to:
9493

95-
- set `config.file` to where the config file is mounted
96-
- expose the default port (9290) or set `web.listen-address` accordingly
94+
- set `config.file` to the path of the config file as seen within the container
95+
- expose the default TCP port (9290) or set `web.listen-address` accordingly
9796

98-
**NOTE:** you should only use containers for collecting remote metrics.
97+
**NOTE:** you should use containers only when collecting remote metrics.
9998

10099
## Configuration
101100

102101
The [configuration](docs/configuration.md) document describes both the
103-
configuration of the IPMI exporter itself as well as providing some guidance
104-
for configuring the Prometheus server to scrape it.
102+
configuration of the IPMI exporter itself as well as
103+
configuring the Prometheus server to scrape it.
105104

106105
## TLS and basic authentication
107106

0 commit comments

Comments
 (0)