Also release docker images for every master commit

[erdii]

[erdii]

ref: https://github.com/thanos-io/thanos/blob/main/Makefile#L5

[SuperQ]

Nice. One question, can we use CircleCI for build and publish pipelines? We have a standard set of templates and tools for doing packaging for Prometheus Community projects. We also have tooling to auto-update various things across projects.

[erdii]

Hey @SuperQ 👋

I had switched away from CircleCI because

• the runs were way too slow
• I was not able to add the quay push secrets there
• and GH actions seemed appropriate in achieving what was needed

but in the end I don't have a strong preference for any CI provider as long as it just works.
That being said: I'd be happy to help moving back to CircleCI as long as the quay secret problem can be solved.
Maybe we can then even push to quay.io/prometheus or quay.io/prometheus-community?

[SuperQ]

Prometheus-Team can handle the quay/github/docker secrets no problem. I though it was setup in the build context, so you wouldn't need to do anything except include the correct context key in your workflows.

We already have https://quay.io/organization/prometheuscommunity.

[SuperQ]

I double-checked, and yes, the org-context has the Quay credentials in it. But it doesn't have a GitHub publisher token in it. I think we've been importing this manually into projects.

[erdii]

@SuperQ do you have permissions to import it? I'd try to carve out time for the switch back when the token is available.
WDYT?

Edit: sry for the long time - work work 😅

[SuperQ]

Sorry, I forgot to update things. The org-context in CircleCI has all of the required env vars, including GITHUB_TOKEN.

[erdii]

Wohoo thank you @SuperQ \o/ let's see when I get to do the work :)

Edit: wait... you are talking about GITHUB_TOKEN but I think we only need quay tokens here anyways