Skip to content

Commit 9370d8d

Browse files
kr0mkr0m
kr0m
authored and
kr0m
committed
Some disks doesnt report device speed correctly, when we assign pd_device_speed metric a string value: Unknown, script execution crashes, in that case assign a 0 speed value.
Signed-off-by: kr0m <[email protected]>
1 parent 34dd42e commit 9370d8d

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

Diff for: storcli.py

+9-3
Original file line numberDiff line numberDiff line change
@@ -353,9 +353,15 @@ def create_metrics_of_physical_drive(physical_drive, detailed_info_array, contro
353353
metrics["pd_link_speed"].labels(controller_index, enclosure, slot).set(
354354
attributes["Link Speed"].split(".")[0]
355355
)
356-
metrics["pd_device_speed"].labels(controller_index, enclosure, slot).set(
357-
attributes["Device Speed"].split(".")[0]
358-
)
356+
# Some disks doesnt report device speed correctly
357+
# when pd_device_speed metric assigns a string value: "Unknown"
358+
# script execution crashes in that case assign a 0 speed value.
359+
if attributes["Device Speed"].split(".")[0] == "Unknown":
360+
metrics["pd_device_speed"].labels(controller_index, enclosure, slot).set('0')
361+
else:
362+
metrics["pd_device_speed"].labels(controller_index, enclosure, slot).set(
363+
attributes["Device Speed"].split(".")[0]
364+
)
359365
metrics["pd_commissioned_spare"].labels(controller_index, enclosure, slot).set(
360366
settings["Commissioned Spare"] == "Yes"
361367
)

0 commit comments

Comments
 (0)