Merge pull request #159 from rsommer/add_cli_env_vars

SuperQ · web-flow · commit 18bf3766a745 · 2024-08-01T14:53:14.000+02:00
Allow connection config via environment variable
diff --git a/pgbouncer_exporter.go b/pgbouncer_exporter.go
@@ -46,7 +46,7 @@ func main() {
 	flag.AddFlags(kingpin.CommandLine, promlogConfig)
 
 	var (
-		connectionStringPointer = kingpin.Flag("pgBouncer.connectionString", "Connection string for accessing pgBouncer.").Default("postgres://postgres:@localhost:6543/pgbouncer?sslmode=disable").String()
+		connectionStringPointer = kingpin.Flag("pgBouncer.connectionString", "Connection string for accessing pgBouncer.").Default("postgres://postgres:@localhost:6543/pgbouncer?sslmode=disable").Envar("PGBOUNCER_EXPORTER_CONNECTION_STRING").String()
 		metricsPath             = kingpin.Flag("web.telemetry-path", "Path under which to expose metrics.").Default("/metrics").String()
 		pidFilePath             = kingpin.Flag("pgBouncer.pid-file", pidFileHelpText).Default("").String()
 	)

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ func main() {`
`46`	`46`	`flag.AddFlags(kingpin.CommandLine, promlogConfig)`
`47`	`47`
`48`	`48`	`var (`
`49`		`- connectionStringPointer = kingpin.Flag("pgBouncer.connectionString", "Connection string for accessing pgBouncer.").Default("postgres://postgres:@localhost:6543/pgbouncer?sslmode=disable").String()`
	`49`	`+ connectionStringPointer = kingpin.Flag("pgBouncer.connectionString", "Connection string for accessing pgBouncer.").Default("postgres://postgres:@localhost:6543/pgbouncer?sslmode=disable").Envar("PGBOUNCER_EXPORTER_CONNECTION_STRING").String()`
`50`	`50`	`metricsPath = kingpin.Flag("web.telemetry-path", "Path under which to expose metrics.").Default("/metrics").String()`
`51`	`51`	`pidFilePath = kingpin.Flag("pgBouncer.pid-file", pidFileHelpText).Default("").String()`
`52`	`52`	`)`