Skip to content

Commit 2e9d43e

Browse files
committed
Fix metrics filter with colon : in query value
Example of a metric filter affected by this: ``` cloudsql.googleapis.com/database:resource.labels.database_id=project-id:database-name ``` Signed-off-by: Daniel Kontsek <[email protected]>
1 parent 11d3a0a commit 2e9d43e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

utils/utils.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func SplitExtraFilter(extraFilter string, separator string) (string, string) {
4646
if mPrefix[0] == extraFilter {
4747
return "", ""
4848
}
49-
return mPrefix[0], strings.Join(mPrefix[1:], "")
49+
return mPrefix[0], strings.Join(mPrefix[1:], separator)
5050
}
5151

5252
func ProjectResource(projectID string) string {

utils/utils_test.go

+8
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,11 @@ var _ = Describe("ProjectResource", func() {
3131
Expect(ProjectResource("fake-project-1")).To(Equal("projects/fake-project-1"))
3232
})
3333
})
34+
35+
var _ = Describe("SplitExtraFilter", func() {
36+
It("returns a metric prefix and filter query", func() {
37+
metricPrefix, filterQuery := SplitExtraFilter("This_is__a-MetricName.Example/with:filter.name=filter:value", ":")
38+
Expect(metricPrefix).To(Equal("This_is__a-MetricName.Example/with"))
39+
Expect(filterQuery).To(Equal("filter.name=filter:value"))
40+
})
41+
})

0 commit comments

Comments
 (0)