config: validate module probe on unmarshal

Signed-off-by: Jakob Hahn <[email protected]>

Author: Jakob3xD

config/config.go

@@ -24,6 +24,7 @@ import (
 	"reflect"
 	"regexp"
 	"runtime"
+	"slices"
 	"sort"
 	"strconv"
 	"strings"
@@ -350,7 +351,7 @@ func (s *Module) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	if err := unmarshal((*plain)(s)); err != nil {
 		return err
 	}
-	return nil
+	return s.validate()
 }
 
 // UnmarshalJSON implements the json.Unmarshaler interface.
@@ -390,7 +391,7 @@ func (s *Module) UnmarshalJSON(data []byte) error {
 				return err
 			}
 		default:
-			return fmt.Errorf("invalid duration: %#v", tmp)
+			return fmt.Errorf("invalid duration '%#v'", tmp)
 		}
 	}
 	*s = Module{
@@ -402,6 +403,13 @@ func (s *Module) UnmarshalJSON(data []byte) error {
 		DNS:     tmp.DNS,
 		GRPC:    tmp.GRPC,
 	}
+	return s.validate()
+}
+
+func (s *Module) validate() error {
+	if !slices.Contains([]string{"http", "tcp", "icmp", "dns", "grpc"}, s.Prober) {
+		return fmt.Errorf("prober '%s' is invalid", s.Prober)
+	}
 	return nil
 }
 

config/config_test.go

@@ -224,6 +224,11 @@ func TestLoadBadConfigs(t *testing.T) {
 			want:   `error parsing config file: setting body and body_file both are not allowed`,
 			format: []string{"yml", "json"},
 		},
+		{
+			input:  "testdata/invalid-module-prober",
+			want:   `error parsing config file: prober 'hTTp' is invalid`,
+			format: []string{"yml", "json"},
+		},
 	}
 	for _, test := range tests {
 		require.NoError(t, yamlToJson(t, test.input))

config/testdata/invalid-module-prober.yml

@@ -0,0 +1,5 @@
+modules:
+  http_2xx:
+    prober: hTTp
+    timeout: 5s
+    http: