Skip to content

Commit 5654a21

Browse files
authored
Merge pull request #2010 from ProjectMutilation/fix-handle-leak
fix(registry): prevent file descriptor leak in WriteToTextfile
2 parents 02eaf49 + 08baa43 commit 5654a21

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

prometheus/registry.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -641,10 +641,12 @@ func WriteToTextfile(filename string, g Gatherer) error {
641641

642642
mfs, err := g.Gather()
643643
if err != nil {
644+
tmp.Close()
644645
return err
645646
}
646647
for _, mf := range mfs {
647648
if _, err := expfmt.MetricFamilyToText(tmp, mf); err != nil {
649+
tmp.Close()
648650
return err
649651
}
650652
}

0 commit comments

Comments
 (0)