remote: simplified Store interface; renamed Handler to WriteHandler#1855
Merged
Conversation
…encapsulated write response * Re store: We don't need to pass context - you have it in http.Request.Context() * Re rename: Technically we have API and Handler is only for remote write, not read, thus making space for "read" one day. * Re write response: I made read flow private, otherwise it's confusing how to use this structure from outside. Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
prwclient-fixes
branch
from
6b0c626 to
f455009
Compare
saswatamcode
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also: