Skip to content

Commit ca6145f

Browse files
fscellosfstab
authored andcommitted
Taking account of Fabian's propositions
Signed-off-by: Fabrice Scellos <[email protected]>
1 parent 4edf911 commit ca6145f

File tree

4 files changed

+29
-35
lines changed

4 files changed

+29
-35
lines changed

Diff for: integration_tests/it_exemplars_otel_agent/pom.xml

+7-20
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@
2020
<type>pom</type>
2121
<scope>import</scope>
2222
</dependency>
23+
<dependency>
24+
<groupId>io.prometheus</groupId>
25+
<artifactId>simpleclient_bom</artifactId>
26+
<version>${project.version}</version>
27+
<type>pom</type>
28+
<scope>import</scope>
29+
</dependency>
2330
</dependencies>
2431
</dependencyManagement>
2532

@@ -33,26 +40,6 @@
3340
<artifactId>okhttp</artifactId>
3441
<scope>compile</scope>
3542
</dependency>
36-
<dependency>
37-
<groupId>io.prometheus</groupId>
38-
<artifactId>simpleclient</artifactId>
39-
<version>${project.version}</version>
40-
</dependency>
41-
<dependency>
42-
<groupId>io.prometheus</groupId>
43-
<artifactId>simpleclient_tracer_common</artifactId>
44-
<version>${project.version}</version>
45-
</dependency>
46-
<dependency>
47-
<groupId>io.prometheus</groupId>
48-
<artifactId>simpleclient_tracer_otel</artifactId>
49-
<version>${project.version}</version>
50-
</dependency>
51-
<dependency>
52-
<groupId>io.prometheus</groupId>
53-
<artifactId>simpleclient_tracer_otel_agent</artifactId>
54-
<version>${project.version}</version>
55-
</dependency>
5643
<dependency>
5744
<groupId>io.prometheus</groupId>
5845
<artifactId>simpleclient_hotspot</artifactId>

Diff for: simpleclient_bom/pom.xml

+5
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@
7171
<artifactId>simpleclient_httpserver</artifactId>
7272
<version>${project.version}</version>
7373
</dependency>
74+
<dependency>
75+
<groupId>io.prometheus</groupId>
76+
<artifactId>simpleclient_tracer_common</artifactId>
77+
<version>${project.version}</version>
78+
</dependency>
7479
<dependency>
7580
<groupId>io.prometheus</groupId>
7681
<artifactId>simpleclient_jetty</artifactId>

Diff for: simpleclient_tracer/simpleclient_tracer_otel/src/main/java/io/prometheus/client/exemplars/tracer/otel/OpenTelemetrySpanContextSupplier.java

+16-15
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@
77

88
public class OpenTelemetrySpanContextSupplier implements SpanContextSupplier {
99

10-
public static boolean isAvailable() {
10+
public static boolean isAvailable() {
1111
try {
1212
if ("inactive".equalsIgnoreCase(System.getProperties().getProperty("io.prometheus.otelExemplars"))) {
1313
return false;
1414
}
1515
OpenTelemetrySpanContextSupplier test = new OpenTelemetrySpanContextSupplier();
1616
test.getSpanId();
1717
test.getTraceId();
18+
test.isSampled();
1819
return true;
1920
} catch (LinkageError ignored) {
2021
// NoClassDefFoundError:
@@ -25,20 +26,20 @@ public static boolean isAvailable() {
2526
}
2627
}
2728

28-
@Override
29-
public String getTraceId() {
30-
String traceId = Span.current().getSpanContext().getTraceId();
31-
return TraceId.isValid(traceId) ? traceId : null;
32-
}
29+
@Override
30+
public String getTraceId() {
31+
String traceId = Span.current().getSpanContext().getTraceId();
32+
return TraceId.isValid(traceId) ? traceId : null;
33+
}
3334

34-
@Override
35-
public String getSpanId() {
36-
String spanId = Span.current().getSpanContext().getSpanId();
37-
return SpanId.isValid(spanId) ? spanId : null;
38-
}
35+
@Override
36+
public String getSpanId() {
37+
String spanId = Span.current().getSpanContext().getSpanId();
38+
return SpanId.isValid(spanId) ? spanId : null;
39+
}
3940

40-
@Override
41-
public boolean isSampled() {
42-
return Span.current().getSpanContext().isSampled();
43-
}
41+
@Override
42+
public boolean isSampled() {
43+
return Span.current().getSpanContext().isSampled();
44+
}
4445
}

Diff for: simpleclient_tracer/simpleclient_tracer_otel_agent/src/main/java/io/prometheus/client/exemplars/tracer/otel_agent/OpenTelemetryAgentSpanContextSupplier.java

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public static boolean isAvailable() {
2020
OpenTelemetryAgentSpanContextSupplier test = new OpenTelemetryAgentSpanContextSupplier();
2121
test.getSpanId();
2222
test.getTraceId();
23+
test.isSampled();
2324
return true;
2425
} catch (LinkageError ignored) {
2526
// NoClassDefFoundError:

0 commit comments

Comments
 (0)