Skip to content

Commit f47b2b5

Browse files
committed
document why we cannot have "le" label alongside classic buckets
Signed-off-by: György Krajcsovits <[email protected]>
1 parent d10c4c4 commit f47b2b5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/specs/om/open_metrics_spec_2_0.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ If a Histogram includes +Inf or -Inf measurement, then +Inf or -Inf MUST be coun
264264

265265
A Histogram MetricPoint SHOULD have a Timestamp value called Start Timestamp. This can help ingestors discern between new metrics and long-running ones it did not see before.
266266

267-
If the Histogram Metric has MetricPoints with Classic Buckets, the Histogram's Metric's LabelSet MUST NOT have a "le" label name.
267+
If the Histogram Metric has MetricPoints with Classic Buckets, the Histogram's Metric's LabelSet MUST NOT have a "le" label name, because in case the MetricPoints are stored as classic histogram series with the `_bucket` suffix, then the "le" label in the Histogram will conflict with the "le" label generated from the bucket thresholds.
268268

269269
##### Classic Buckets
270270

@@ -352,7 +352,7 @@ A GaugeHistogram SHOULD NOT include NaN measurements as including NaN in the Gsu
352352

353353
If a GaugeHistogram includes +Inf or -Inf measurement, then +Inf or -Inf MUST be counted in Gcount and MUST be added to the Gsum, potentially resulting in +Inf, -Inf or NaN in the Gsum, the later for example in case of adding +Inf to -Inf. Note that in this case the Gsum of finite measurements is masked until the next reset of the Histogram.
354354

355-
If the GaugeHistogram Metric has MetricPoints with Classic Buckets, the GaugeHistogram's Metric's LabelSet MUST NOT have a "le" label name.
355+
If the GaugeHistogram Metric has MetricPoints with Classic Buckets, the GaugeHistogram's Metric's LabelSet MUST NOT have a "le" label name, because in case the MetricPoints are stored as classic histogram series with the `_bucket` suffix, then the "le" label in the GaugeHistogram will conflict with the "le" label generated from the bucket thresholds.
356356

357357
The Classic and Native buckets for a GaugeHistogram follow all the same rules as for a Histogram, with Gcount and Gsum playing the same role as Count and Sum.
358358

0 commit comments

Comments
 (0)