Skip to content

Conversation

@ywwg
Copy link
Member

@ywwg ywwg commented Dec 1, 2025

Fixes #2766

@ywwg ywwg requested a review from krajorama December 1, 2025 17:59
@ywwg ywwg force-pushed the owilliams/utf-8-examples branch 3 times, most recently from 8a9c8bb to bca1e8b Compare December 1, 2025 18:12
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments.

(note: not a huge fan that we refer to the ABNF which might be hard to read for some folks, but I realize that's the source of truth)

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod comments

@ywwg
Copy link
Member Author

ywwg commented Dec 3, 2025

TODO: add a paragraph about what kinds of names don't need to be quoted. Regex is probably fine for this vs ABNF

@ywwg ywwg force-pushed the owilliams/utf-8-examples branch 2 times, most recently from 4352abb to f622c12 Compare December 3, 2025 18:42
@ywwg ywwg force-pushed the owilliams/utf-8-examples branch from f622c12 to d87510a Compare December 3, 2025 18:43
@ywwg ywwg merged commit 532758b into main Dec 3, 2025
6 checks passed
@ywwg ywwg deleted the owilliams/utf-8-examples branch December 3, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OM2.0: Add examples for new ABNF

5 participants