Skip to content

Commit f26b115

Browse files
authored
fix: Fixed release.sh to correctly not include 'v' in a release tag (#1546)
Signed-off-by: dhoard <doug.hoard@gmail.com>
1 parent 9b26427 commit f26b115

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

RELEASING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
- Signs each jar with GPG
4444
- Generates SHA256 checksums
4545
9. Commits release on release branch
46-
10. Creates annotated tag: `v{VERSION}`
46+
10. Creates annotated tag: `{VERSION}`
4747
11. Pushes release branch and tag to remote
4848
12. Switches back to main branch
4949
13. Sets post-release version: `{VERSION}-POST`

release.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ check_git_state() {
181181
check_no_existing_release() {
182182
local ver="$1"
183183
local release_branch="release-${ver}"
184-
local tag_name="v${ver}"
184+
local tag_name="${ver}"
185185

186186
log_info "Checking for existing release"
187187

@@ -306,7 +306,7 @@ commit_release() {
306306

307307
tag_release() {
308308
local ver="$1"
309-
local tag_name="v${ver}"
309+
local tag_name="${ver}"
310310

311311
log_info "Creating git tag"
312312

@@ -318,7 +318,7 @@ tag_release() {
318318
push_release() {
319319
local ver="$1"
320320
local release_branch="release-${ver}"
321-
local tag_name="v${ver}"
321+
local tag_name="${ver}"
322322

323323
log_info "Pushing release to remote"
324324

@@ -408,7 +408,7 @@ main() {
408408
log_info "This will:"
409409
log_info " - Create branch: release-${version}"
410410
log_info " - Build and deploy to Maven Central"
411-
log_info " - Create git tag: v${version}"
411+
log_info " - Create git tag: ${version}"
412412
log_info " - Push to remote: ${git_remote}"
413413
log_info " - Sign artifacts with GPG key: ${gpg_key_id:-default}"
414414
echo ""

0 commit comments

Comments
 (0)