Skip to content

Commit df97ae1

Browse files
committed
Remove duplicated block
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
1 parent d4945e1 commit df97ae1

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

proposals/0072-remote-write-restart-from-checkpoint.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ A basic replay to accomplishing all non-stretch goals would be as follows
7575

7676
### Code flow
7777

78-
Enabling replay will require changes across `remote.WriteStorage`, `remote.QueueManager`, and `wlog.Watcher`. Implementing https://github.com/prometheus/prometheus/issues/17616 will help as it will provide a hook to signal when segments have been fully read from the watcher through `remote.WriteStorage`. Anytime the `wlog.Watcher` [changes the current segment](https://github.com/prometheus/prometheus/blob/18efd9d629c467877ebe674bbc1edbba8abe54be/tsdb/wlog/watcher.go#L314) the following would happen,
79-
8078
1. Adding another configurable timer to [`remote.WriteStorage.run()`](https://github.com/prometheus/prometheus/blob/f50ff0a40ad4ef24d9bb8e81a6546c8c994a924a/storage/remote/write.go#L114-L125) periodically persisting the current segments for each queue.
8179
2. Ensure `remote.WriteStorage.Close()` will also attempt to write current segments
8280
3. Read persisted queue segment positions in `remote.NewWriteStorage()`

0 commit comments

Comments
 (0)