[hmr] writing to `globals()` don't take effect

[CNSeniorious000]

Related

• [hmr] Should support user-defined module-level __getattr__ #207

Reproduction

# foo.py

globals()["bar"] = 123

# main.py

import foo

print(foo.bar)

You will get a AttributeError: bar

Caused by

pyth-on-line/src/python/common/reactivity/hmr/core.py

Lines 31 to 44 in 8babf49

	class NamespaceProxy(Reactive[str, Any]):
	def __init__(self, initial: MutableMapping, check_equality=True):
	super().__init__(initial, check_equality)
	self._original = initial
	def __setitem__(self, key, value):
	self._original[key] = value
	return super().__setitem__(key, value)
	def __delitem__(self, key):
	del self._original[key]
	return super().__delitem__(key)

Not reading from the proxied namespace

Discussion

1. We can proxy __getattr__ too here, but writing to gloabls() won't cause reactions. If we decided to use this approach, we can inform users about this behavior in the docs.
2. We can force globals() to return the proxy itself by patching the globals key in the namespace or in the __builtins__ key, and patch any function's by FunctionType(func.__code__, { ... }). We may also need to patch classes too, but I'm not sure know how to do that.

[linear]

PROM-42 [hmr] writing to `globals()` don't take effect