Merge pull request apache#132 from proost/perf-reduce-serialization

proost · web-flow · commit d5f6e042c8f4 · 2026-03-06T12:28:21.000+09:00
perf: reduce unnecessary serialization in KLL sketch
diff --git a/kll/items_sketch.go b/kll/items_sketch.go
@@ -593,7 +593,6 @@ func (s *ItemsSketch[C]) currentSerializedSizeBytes() (int, error) {
 		}
 		totalBytes = _DATA_START_ADR_SINGLE_ITEM + v
 	} else if tgtStructure == _COMPACT_FULL {
-
 		totalBytes = _DATA_START_ADR + s.getLevelsArrSizeBytes(tgtStructure) + s.getMinMaxSizeBytes() + s.getRetainedItemsSizeBytes()
 	} else { //structure = UPDATABLE
 		return 0, fmt.Errorf("updatable serialization not implemented")
@@ -670,7 +669,11 @@ func (s *ItemsSketch[C]) getRetainedItemsByteArr() []byte {
 }
 
 func (s *ItemsSketch[C]) getRetainedItemsSizeBytes() int {
-	return len(s.getRetainedItemsByteArr())
+	retainedSize := 0
+	for i := s.levels[0]; i < s.levels[s.numLevels]; i++ {
+		retainedSize += s.serde.SizeOf(s.items[i])
+	}
+	return retainedSize
 }
 
 func (s *ItemsSketch[C]) setupSortedView() error {

Original file line number	Diff line number	Diff line change
`@@ -593,7 +593,6 @@ func (s *ItemsSketch[C]) currentSerializedSizeBytes() (int, error) {`
`593`	`593`	`}`
`594`	`594`	`totalBytes = _DATA_START_ADR_SINGLE_ITEM + v`
`595`	`595`	`} else if tgtStructure == _COMPACT_FULL {`
`596`		`-`
`597`	`596`	`totalBytes = _DATA_START_ADR + s.getLevelsArrSizeBytes(tgtStructure) + s.getMinMaxSizeBytes() + s.getRetainedItemsSizeBytes()`
`598`	`597`	`} else { //structure = UPDATABLE`
`599`	`598`	`return 0, fmt.Errorf("updatable serialization not implemented")`
`@@ -670,7 +669,11 @@ func (s *ItemsSketch[C]) getRetainedItemsByteArr() []byte {`
`670`	`669`	`}`
`671`	`670`
`672`	`671`	`func (s *ItemsSketch[C]) getRetainedItemsSizeBytes() int {`
`673`		`- return len(s.getRetainedItemsByteArr())`
	`672`	`+ retainedSize := 0`
	`673`	`+ for i := s.levels[0]; i < s.levels[s.numLevels]; i++ {`
	`674`	`+ retainedSize += s.serde.SizeOf(s.items[i])`
	`675`	`+ }`
	`676`	`+ return retainedSize`
`674`	`677`	`}`
`675`	`678`
`676`	`679`	`func (s *ItemsSketch[C]) setupSortedView() error {`