Skip to content

Commit ec6a269

Browse files
authored
Merge pull request apache#117 from apache/sampling-guard-test
Add guard for test in sampling sketch
2 parents b0dd394 + 2d2da9d commit ec6a269

1 file changed

Lines changed: 18 additions & 3 deletions

File tree

sampling/compatibility_test.go

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,12 @@ func TestGenerateGoBinariesForCompatibilityTesting(t *testing.T) {
251251

252252
// TestSerializationCompatibilityEmpty tests deserialization of an empty sketch.
253253
func TestSerializationCompatibilityEmpty(t *testing.T) {
254-
data, err := os.ReadFile(filepath.Join(internal.GoPath, "reservoir_items_long_empty_k128_go.sk"))
254+
filename := filepath.Join(internal.GoPath, "reservoir_items_long_empty_k128_go.sk")
255+
if _, err := os.Stat(filename); os.IsNotExist(err) {
256+
t.Skipf("Go file not found: %s", filename)
257+
return
258+
}
259+
data, err := os.ReadFile(filename)
255260
assert.NoError(t, err)
256261

257262
sketch, err := NewReservoirItemsSketchFromSlice[int64](data, Int64SerDe{})
@@ -277,7 +282,12 @@ func TestSerializationCompatibilityExact(t *testing.T) {
277282

278283
for _, tc := range testCases {
279284
t.Run(tc.filename, func(t *testing.T) {
280-
data, err := os.ReadFile(filepath.Join(internal.GoPath, tc.filename))
285+
filename := filepath.Join(internal.GoPath, tc.filename)
286+
if _, err := os.Stat(filename); os.IsNotExist(err) {
287+
t.Skipf("Go file not found: %s", filename)
288+
return
289+
}
290+
data, err := os.ReadFile(filename)
281291
assert.NoError(t, err)
282292

283293
sketch, err := NewReservoirItemsSketchFromSlice[int64](data, Int64SerDe{})
@@ -303,7 +313,12 @@ func TestSerializationCompatibilityWithSampling(t *testing.T) {
303313

304314
for _, tc := range testCases {
305315
t.Run(tc.filename, func(t *testing.T) {
306-
data, err := os.ReadFile(filepath.Join(internal.GoPath, tc.filename))
316+
filename := filepath.Join(internal.GoPath, tc.filename)
317+
if _, err := os.Stat(filename); os.IsNotExist(err) {
318+
t.Skipf("Go file not found: %s", filename)
319+
return
320+
}
321+
data, err := os.ReadFile(filename)
307322
assert.NoError(t, err)
308323

309324
sketch, err := NewReservoirItemsSketchFromSlice[int64](data, Int64SerDe{})

0 commit comments

Comments
 (0)