Merge pull request #422 from propeller-heads/cluster-test/dc/accept-all-slippage-values

feat: Set min amount out to 1 so that execution doesn't fail

Author: dianacarvalho1

Cargo.lock

@@ -44,7 +44,6 @@ pub fn encode_swap(
     sell_token: &Token,
     buy_token: &Token,
     amount_in: BigUint,
-    expected_amount_out: BigUint,
     chain: Chain,
 ) -> miette::Result<(Solution, Transaction)> {
     let solution = create_solution(
@@ -53,7 +52,6 @@ pub fn encode_swap(
         sell_token.clone(),
         buy_token.clone(),
         amount_in.clone(),
-        expected_amount_out.clone(),
     )?;
     let encoded_solution = {
         let encoder = TychoRouterEncoderBuilder::new()
@@ -81,7 +79,6 @@ fn create_solution(
     sell_token: Token,
     buy_token: Token,
     amount_in: BigUint,
-    expected_amount_out: BigUint,
 ) -> miette::Result<Solution> {
     let user_address = Bytes::from_str(USER_ADDR).into_diagnostic()?;
 
@@ -92,26 +89,16 @@ fn create_solution(
             .estimated_amount_in(amount_in.clone())
             .build();
 
-    // Compute a minimum amount out
-    //
-    // # ⚠️ Important Responsibility Note
-    // For maximum security, in production code, this minimum amount out should be computed
-    // from a third-party source.
-    let slippage = 0.0025; // 0.25% slippage
-    let bps = BigUint::from(10_000u32);
-    let slippage_percent = BigUint::from((slippage * 10000.0) as u32);
-    let multiplier = &bps - slippage_percent;
-    let min_amount_out = (expected_amount_out * &multiplier) / &bps;
-
-    // Then we create a solution object with the previous swap
     Ok(Solution {
         sender: user_address.clone(),
         receiver: user_address,
         given_token: sell_token.address,
         given_amount: amount_in,
         checked_token: buy_token.address,
         exact_out: false, // it's an exact in solution
-        checked_amount: min_amount_out,
+        // We want to keep track of how bad the slippage really is and not just error at execution
+        // time. NEVER DO THIS IN PRODUCTION!
+        checked_amount: BigUint::from(1u64),
         swaps: vec![simple_swap],
         ..Default::default()
     })

tycho-integration-test/src/execution/encoding.rs

@@ -677,7 +677,6 @@ async fn process_state(
             token_in,
             token_out,
             amount_in.clone(),
-            expected_amount_out.clone(),
             chain,
         ) {
             Ok(res) => res,

tycho-integration-test/src/main.rs

@@ -180,7 +180,10 @@ pub async fn create_metrics_exporter(port: u16) -> Result<tokio::task::JoinHandl
         .map_err(|e| miette::miette!("Failed to set buckets: {}", e))?
         .set_buckets_for_metric(
             Matcher::Full("tycho_integration_simulation_execution_slippage_ratio".to_string()),
-            &[-0.25, -0.2, -0.15, -0.1, -0.05, -0.01, 0.0, 0.01, 0.05, 0.1, 0.15, 0.2, 0.25],
+            &[
+                -10.0, -1.0, -0.5, -0.25, -0.2, -0.15, -0.1, -0.05, -0.01, 0.0, 0.01, 0.05, 0.1,
+                0.15, 0.2, 0.25, 0.5, 1.0, 10.0,
+            ],
         )
         .map_err(|e| miette::miette!("Failed to set buckets: {}", e))?
         .set_buckets_for_metric(