Merge pull request #398 from propeller-heads/usv4/tnl/ENG-5139-fix-panic

fix: (USV4) Used checked sub and propagate error

Author: tamaralipows

src/evm/protocol/uniswap_v4/state.rs

@@ -2,7 +2,7 @@ use std::{any::Any, collections::HashMap};
 
 use alloy::primitives::{Address, Sign, I256, U256};
 use num_bigint::BigUint;
-use num_traits::{ToPrimitive, Zero};
+use num_traits::{CheckedSub, ToPrimitive, Zero};
 use revm::primitives::I128;
 use tracing::trace;
 use tycho_common::{
@@ -383,8 +383,19 @@ impl ProtocolSim for UniswapV4State {
                     let y2 = self.get_amount_out(x2.clone(), base, quote)?;
 
                     // Calculate the marginal price
-                    let num = &y2.amount - &y1.amount;
-                    let den = &x2 - &x1;
+                    let num = y2
+                        .amount
+                        .checked_sub(&y1.amount)
+                        .ok_or_else(|| {
+                            SimulationError::FatalError(
+                                "Cannot calculate spot price: y2 < y1".to_string(),
+                            )
+                        })?;
+                    let den = x2.checked_sub(&x1).ok_or_else(|| {
+                        SimulationError::FatalError(
+                            "Cannot calculate spot price: x2 < x1".to_string(),
+                        )
+                    })?;
 
                     if den == BigUint::from(0u64) {
                         return Err(SimulationError::FatalError(