feat: support disabling token overwrite #362
Open
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach030
changed the title
zach030
force-pushed
the
feat/disable-token-overwrite
branch
from
75b46d0 to
709ddd9
Compare
zizou0x
reviewed
Nov 19, 2025
Contributor
zizou0x
left a comment
zizou0x
left a comment
There was a problem hiding this comment.
Thanks for this one! Just a few small comments
Comment on lines
+524
to
+527
| for token in &self.disable_overwrite_tokens { | ||
| let overwrites = TokenProxyOverwriteFactory::new(*token, None); | ||
| balance_overwrites.extend(overwrites.get_overwrites()) | ||
| } |
Contributor
There was a problem hiding this comment.
I don't understand how this works, why do we need to create an empty overwrite factory? Can't we just remove entries from balance_overwrites?
Comment on lines
+419
to
+424
| if self | ||
| .disable_overwrite_tokens | ||
| .contains(&addr) | ||
| { | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
Can't we just remove them from the overwrites but keep balances stored?
This is because people will expect this to contain all the balances, it's a bit shady that we have this edge case that makes them being ignored.
| let potential_rebase_tokens: HashSet<Address> = if let Some(bytes) = snapshot | ||
| .component | ||
| .static_attributes | ||
| .get("rebase_tokens") |
Contributor
There was a problem hiding this comment.
I find this name weird, I'll think about it but I think we should make it more obvious what it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.