PHPStorm code inspection errors

[paweltfit]

Hello,

During its inspection, PHPStorm returns errors like these in generated base query classes, complaining that the method Collection is already defined:

The code still works fine but obviously it's a bit inconvenient. I dealt with it by removing the following piece of code from the baseQueryClassHeader.php file, deleting all query classes and then re-running propel model:build:

<?php foreach($columns as $column):?>
 * @method     <?= $modelClass ?>[]|Collection findBy<?= $column->getPhpName() ?>(<?= $column->getPhpType() ?>|array<<?= $column->getPhpType() ?>> $<?= $column->getName() ?>) Return <?= $modelClass ?> objects filtered by the <?= $column->getName() ?> column
 * @psalm-method Collection&\Traversable<<?= $modelClass ?>> findBy<?= $column->getPhpName() ?>(<?= $column->getPhpType() ?>|array<<?= $column->getPhpType() ?>> $<?= $column->getName() ?>) Return <?= $modelClass ?> objects filtered by the <?= $column->getName() ?> column
<?php endforeach;?>

Another issue is the word match in the same file - it's now a reserved word in PHP so some comments were highlighting it as an error. I fixed it by putting match between single quotes on line 67.

What are your thoughts?

[tsybenko]

@paweltfit, I see a fully qualified class name has been missed here. Just provided a fix for that here - #1989

[PhilinTv]

@tsybenko normally FQCN should not be required here, as there is a declaration of the Collection type in the use statement above. I checked in the older version of PHPStorm 2023, and it doesn't show such an error (it doesn't understand intersection type & either, not not error).

Does FQCN solve the problem in the newer versions?

[PhilinTv]

After an update to PHPStorm to 2023.3.3, I can also see it. Phpstorm started to wrongly recognise psalm notations: here it recognised Collection as a class name, however the right class name is "findBy..".

[PhilinTv]

@paweltfit Thanks for reporting this issue with new IDE version.
Please submit the "match" issue separately.

[smhg]

@paweltfit @tsybenko is the above still an issue in current PHPStorm?
If not, we can close this issue and the accompanying PR. Otherwise please feel free to address the review in #1989.