Merge pull request #55 from propublica/develop

small updates

Author: aaronbrezel

__tests__/menu.test.ts

@@ -160,7 +160,10 @@ describe("importDriveLinks", () => {
       getFolderById: jest.fn().mockReturnValue(mockFolder),
     };
 
-    importDriveLinks({ folderUrl: "https://drive.google.com/drive/folders/abc123", outputCol: "source_drive" });
+    importDriveLinks({
+      folderUrl: "https://drive.google.com/drive/folders/abc123",
+      outputCol: "source_drive",
+    });
 
     expect(mockSetValues).toHaveBeenCalledWith([["https://drive.google.com/file/1"]]);
   });

__tests__/services.test.ts

@@ -130,7 +130,10 @@ describe("prepRecipe", () => {
 describe("importDriveLinks", () => {
   it("calls google.script.run.importDriveLinks with config and jobId and resolves", async () => {
     const handlers = captureHandlers();
-    const config = { folderUrl: "https://drive.google.com/drive/folders/abc", outputCol: "source_drive" };
+    const config = {
+      folderUrl: "https://drive.google.com/drive/folders/abc",
+      outputCol: "source_drive",
+    };
     const promise = services.importDriveLinks(config, "job-1");
     handlers.resolve(undefined);
     await expect(promise).resolves.toBeUndefined();
@@ -139,7 +142,10 @@ describe("importDriveLinks", () => {
 
   it("rejects on failure", async () => {
     const handlers = captureHandlers();
-    const config = { folderUrl: "https://drive.google.com/drive/folders/abc", outputCol: "source_drive" };
+    const config = {
+      folderUrl: "https://drive.google.com/drive/folders/abc",
+      outputCol: "source_drive",
+    };
     const promise = services.importDriveLinks(config, "job-1");
     handlers.reject(new Error("drive error"));
     await expect(promise).rejects.toThrow("drive error");

__tests__/utils.test.ts

@@ -196,29 +196,40 @@ describe("getAllFilesRecursive", () => {
   });
 
   it("filters by mimeType prefix when mimeTypePrefixes is provided", () => {
-    const mockDoc = { getUrl: () => "doc-url", getMimeType: () => "application/vnd.google-apps.document" };
+    const mockDoc = {
+      getUrl: () => "doc-url",
+      getMimeType: () => "application/vnd.google-apps.document",
+    };
     const mockPdf = { getUrl: () => "pdf-url", getMimeType: () => "application/pdf" };
     const mockImg = { getUrl: () => "img-url", getMimeType: () => "image/png" };
-    const files = makeFileIterator([]) as any;
     let i = 0;
     const mockFiles = [mockDoc, mockPdf, mockImg];
     const fileIter = { hasNext: () => i < mockFiles.length, next: () => mockFiles[i++] };
     const subfolders = makeFolderIterator([]);
-    const folder = { getFiles: () => fileIter, getFolders: () => subfolders } as unknown as GoogleAppsScript.Drive.Folder;
+    const folder = {
+      getFiles: () => fileIter,
+      getFolders: () => subfolders,
+    } as unknown as GoogleAppsScript.Drive.Folder;
 
     const result: DriveFileInfo[] = [];
     getAllFilesRecursive(folder, result, ["application/"]);
     expect(result.map((f) => f.url)).toEqual(["doc-url", "pdf-url"]);
   });
 
   it("imports all files when mimeTypePrefixes is absent", () => {
-    const mockDoc = { getUrl: () => "doc-url", getMimeType: () => "application/vnd.google-apps.document" };
+    const mockDoc = {
+      getUrl: () => "doc-url",
+      getMimeType: () => "application/vnd.google-apps.document",
+    };
     const mockImg = { getUrl: () => "img-url", getMimeType: () => "image/png" };
     let i = 0;
     const mockFiles = [mockDoc, mockImg];
     const fileIter = { hasNext: () => i < mockFiles.length, next: () => mockFiles[i++] };
     const subfolders = makeFolderIterator([]);
-    const folder = { getFiles: () => fileIter, getFolders: () => subfolders } as unknown as GoogleAppsScript.Drive.Folder;
+    const folder = {
+      getFiles: () => fileIter,
+      getFolders: () => subfolders,
+    } as unknown as GoogleAppsScript.Drive.Folder;
 
     const result: DriveFileInfo[] = [];
     getAllFilesRecursive(folder, result);
@@ -359,7 +370,11 @@ describe("writeJobProgress", () => {
     const mockPut = jest.fn();
     const mockCache = { put: mockPut } as unknown as GoogleAppsScript.Cache.Cache;
 
-    writeJobProgress(mockCache, "job-123", { message: "Processing row 3 of 10", current: 3, total: 10 });
+    writeJobProgress(mockCache, "job-123", {
+      message: "Processing row 3 of 10",
+      current: 3,
+      total: 10,
+    });
 
     expect(mockPut).toHaveBeenCalledWith(
       "job-123",

docs/plans/2026-03-18-import-drive-links-panel-design.md

@@ -14,6 +14,15 @@ Rebuild the "Import Drive Links" tool as a first-class sidebar panel, replacing
 - Delete the old `importDriveLinks` server function and its `runTool` dispatcher entry
 - Lay down patterns that support future Extra tool panels (Sample Rows, Extract Text)
 
+## Migration Pattern
+
+This is the first of three "Extra tool → dedicated panel" migrations. Sample Rows and Extract Text will follow the same steps. Key conventions to carry forward:
+
+- Each tool gets its own config interface in `src/shared/types.ts` (e.g. `SampleRowsConfig`, `ExtractTextConfig`)
+- Each migration removes that tool's entry from the `runTool` TOOLS dispatcher in `index.ts`
+- Once all three tools are migrated, `runTool` becomes dead code — delete the function, its GAS stub in `rollup.config.js`, and its declaration in `google.d.ts`
+- `__tests__/panels/import-drive-links.test.ts` is the reference test pattern for the subsequent panel test files
+
 ## Architecture
 
 ### New files