Fixed extends

Extended fields were being named using the full name, which meant they
always had a dot before them, eg:

message A {
  extensions 1000 to max;
}

extends A {
  optional string extended = 1000;
}

would decode to:

{
  ".extended": "value"
}

This fixes it, using the fields name, rather than the fields full name.

Author: jroper

src/root.js

@@ -260,7 +260,7 @@ var exposeRe = /^[A-Z]/;
 function tryHandleExtension(root, field) {
     var extendedType = field.parent.lookup(field.extend);
     if (extendedType) {
-        var sisterField = new Field(field.fullName, field.id, field.type, field.rule, undefined, field.options);
+        var sisterField = new Field(field.name, field.id, field.type, field.rule, undefined, field.options);
         sisterField.declaringField = field;
         field.extensionField = sisterField;
         extendedType.add(sisterField);

tests/api_root-deferred.js

@@ -17,15 +17,15 @@ tape.test("extension fields", function(test) {
 
     var extendedType = new Type("ExtendedType");
     ns.add(extendedType);
-    var extensionField = extendedType.get(declaringField.fullName);
+    var extensionField = extendedType.get(declaringField.name);
     test.equal(extensionField, declaringField.extensionField, "should become available once their extended type is known");
 
     type.remove(declaringField);
-    extensionField = extendedType.get(declaringField.fullName);
+    extensionField = extendedType.get(declaringField.name);
     test.equal(extensionField, null, "should become unavailable when their declaring field is removed");
 
     type.add(declaringField);
-    extensionField = extendedType.get(declaringField.fullName);
+    extensionField = extendedType.get(declaringField.name);
     test.equal(extensionField, declaringField.extensionField, "should become instantly available if their extended type is knwon");
 
     ns.remove(extendedType);

tests/comp_extend.js

@@ -14,14 +14,28 @@ message A {\
         message Two {\
             extend B.One {\
                 C.Two two = 1000;\
+                string extended = 1001;\
             }\
         }\
     }\
 }";
 
 tape.test("extensions", function(test) {
-    var root = protobuf.parse(proto).root;
-    root.resolveAll();
-    test.pass("should parse and resolve without errors");
-    test.end();
+
+    test.test(" - parsing", function(test) {
+        var root = protobuf.parse(proto).root;
+        root.resolveAll();
+        test.pass("should parse and resolve without errors");
+        test.end();
+    });
+
+    test.test(" - encoding", function(test) {
+        var root = protobuf.parse(proto).root;
+        root.resolveAll();
+        var one = root.lookupType("A.B.One");
+        var original = {extended: "test"};
+        var cycled = one.decode(one.encode(original).finish());
+        test.deepEqual(cycled, original, "should write and read back");
+        test.end();
+    });
 });