fix: ensure camelCase implementation is compatible with Protobuf's ToJsonName #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nName() implementation Added a few test cases that did not work well in the previous version
JustinBeckwith
changed the title
|
This most likely would cause breaking changes in dependents... |
|
To expand on that, if any existing user has a field name that matches one of the patterns of a name that transforms differently as a result of this change, their code that references those fields will break after this change. |
This was referenced May 24, 2019
Closed
|
@murgatroid99 @nicolasnoble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few test cases that did not work well in the previous version
Should fix #1009 and #1130