Skip to content

Commit 9b766a1

Browse files
honglookercopybara-github
authored andcommitted
hpb: update internal tests upb::arena -> hpb::arena
PiperOrigin-RevId: 759255007
1 parent f8e9e01 commit 9b766a1

File tree

3 files changed

+15
-20
lines changed

3 files changed

+15
-20
lines changed

hpb/internal/message_lock_test.cc

+3-5
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,15 @@
1111
#include <mutex>
1212
#include <string>
1313
#include <thread>
14-
#include <vector>
1514

16-
#include <gmock/gmock.h>
1715
#include <gtest/gtest.h>
1816
#include "absl/hash/hash.h"
1917
#include "absl/log/absl_check.h"
2018
#include "google/protobuf/compiler/hpb/tests/test_model.hpb.h"
19+
#include "google/protobuf/hpb/arena.h"
2120
#include "google/protobuf/hpb/extension.h"
2221
#include "google/protobuf/hpb/hpb.h"
2322
#include "upb/mem/arena.hpp"
24-
#include "upb/mini_table/extension.h"
2523

2624
#ifndef ASSERT_OK
2725
#define ASSERT_OK(x) ASSERT_TRUE(x.ok())
@@ -44,7 +42,7 @@ std::string GenerateTestData() {
4442
extension2.set_ext_name("theme_extension");
4543
ABSL_CHECK_OK(
4644
::hpb::SetExtension(&model, ThemeExtension::theme_extension, extension2));
47-
::upb::Arena arena;
45+
hpb::Arena arena;
4846
auto bytes = ::hpb::Serialize(&model, arena);
4947
ABSL_CHECK_OK(bytes);
5048
return std::string(bytes->data(), bytes->size());
@@ -76,7 +74,7 @@ void TestConcurrentExtensionAccess(::hpb::ExtensionRegistry registry) {
7674
EXPECT_EQ((*ext)->ext_name(), "theme_extension");
7775
};
7876
const auto test_serialize = [&] {
79-
::upb::Arena arena;
77+
hpb::Arena arena;
8078
EXPECT_OK(::hpb::Serialize(&parsed_model, arena));
8179
};
8280
const auto test_copy_constructor = [&] {

hpb_generator/tests/extension_test.cc

+5-4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include "google/protobuf/compiler/hpb/tests/test_extension.hpb.h"
1818
#include "google/protobuf/compiler/hpb/tests/test_model.hpb.h"
1919
#include "google/protobuf/hpb/arena.h"
20+
#include "google/protobuf/hpb/hpb.h"
2021
#include "google/protobuf/hpb/requires.h"
2122

2223
namespace {
@@ -427,8 +428,8 @@ TEST(CppGeneratedCode, Parse) {
427428
ThemeExtension extension1;
428429
extension1.set_ext_name("Hello World");
429430
EXPECT_EQ(true, ::hpb::SetExtension(&model, theme, extension1).ok());
430-
::upb::Arena arena;
431-
auto bytes = ::hpb::Serialize(&model, arena);
431+
hpb::Arena arena;
432+
auto bytes = hpb::Serialize(&model, arena);
432433
EXPECT_EQ(true, bytes.ok());
433434
TestModel parsed_model = ::hpb::Parse<TestModel>(bytes.value()).value();
434435
EXPECT_EQ("Test123", parsed_model.str1());
@@ -441,7 +442,7 @@ TEST(CppGeneratedCode, ParseIntoPtrToModel) {
441442
ThemeExtension extension1;
442443
extension1.set_ext_name("Hello World");
443444
EXPECT_EQ(true, ::hpb::SetExtension(&model, theme, extension1).ok());
444-
::upb::Arena arena;
445+
hpb::Arena arena;
445446
auto bytes = ::hpb::Serialize(&model, arena);
446447
EXPECT_EQ(true, bytes.ok());
447448
::hpb::Ptr<TestModel> parsed_model = ::hpb::CreateMessage<TestModel>(arena);
@@ -461,7 +462,7 @@ TEST(CppGeneratedCode, ParseWithExtensionRegistry) {
461462
EXPECT_EQ(true, ::hpb::SetExtension(&model, ThemeExtension::theme_extension,
462463
extension1)
463464
.ok());
464-
::upb::Arena arena;
465+
hpb::Arena arena;
465466
auto bytes = ::hpb::Serialize(&model, arena);
466467
EXPECT_EQ(true, bytes.ok());
467468

hpb_generator/tests/test_generated.cc

+7-11
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,9 @@
66
// https://developers.google.com/open-source/licenses/bsd
77

88
#include <cstdint>
9-
#include <iterator>
109
#include <limits>
1110
#include <memory>
12-
#include <utility>
1311

14-
#include <gmock/gmock.h>
1512
#include <gtest/gtest.h>
1613
#include "absl/status/statusor.h"
1714
#include "absl/strings/string_view.h"
@@ -26,7 +23,6 @@
2623
#include "google/protobuf/hpb/hpb.h"
2724
#include "google/protobuf/hpb/ptr.h"
2825
#include "google/protobuf/hpb/requires.h"
29-
#include "upb/mem/arena.hpp"
3026

3127
namespace {
3228

@@ -412,18 +408,18 @@ TEST(CppGeneratedCode, MessageMapStringKeyAndInt32Value) {
412408
TEST(CppGeneratedCode, SerializeUsingArena) {
413409
TestModel model;
414410
model.set_str1("Hello World");
415-
::upb::Arena arena;
411+
hpb::Arena arena;
416412
absl::StatusOr<absl::string_view> bytes = ::hpb::Serialize(&model, arena);
417413
EXPECT_EQ(true, bytes.ok());
418414
TestModel parsed_model = ::hpb::Parse<TestModel>(bytes.value()).value();
419415
EXPECT_EQ("Hello World", parsed_model.str1());
420416
}
421417

422418
TEST(CppGeneratedCode, SerializeProxyUsingArena) {
423-
::upb::Arena message_arena;
419+
hpb::Arena message_arena;
424420
TestModel::Proxy model_proxy = ::hpb::CreateMessage<TestModel>(message_arena);
425421
model_proxy.set_str1("Hello World");
426-
::upb::Arena arena;
422+
hpb::Arena arena;
427423
absl::StatusOr<absl::string_view> bytes =
428424
::hpb::Serialize(&model_proxy, arena);
429425
EXPECT_EQ(true, bytes.ok());
@@ -434,8 +430,8 @@ TEST(CppGeneratedCode, SerializeProxyUsingArena) {
434430
TEST(CppGeneratedCode, SerializeNestedMessageUsingArena) {
435431
TestModel model;
436432
model.mutable_recursive_child()->set_str1("Hello World");
437-
::upb::Arena arena;
438-
::hpb::Ptr<const TestModel> child = model.recursive_child();
433+
hpb::Arena arena;
434+
hpb::Ptr<const TestModel> child = model.recursive_child();
439435
absl::StatusOr<absl::string_view> bytes = ::hpb::Serialize(child, arena);
440436
EXPECT_EQ(true, bytes.ok());
441437
TestModel parsed_model = ::hpb::Parse<TestModel>(bytes.value()).value();
@@ -452,14 +448,14 @@ TEST(CppGeneratedCode, NameCollisions) {
452448

453449
TEST(CppGeneratedCode, SharedPointer) {
454450
std::shared_ptr<TestModel> model = std::make_shared<TestModel>();
455-
::upb::Arena arena;
451+
hpb::Arena arena;
456452
auto bytes = ::hpb::Serialize(model.get(), arena);
457453
EXPECT_TRUE(::hpb::Parse(model.get(), bytes.value()));
458454
}
459455

460456
TEST(CppGeneratedCode, UniquePointer) {
461457
auto model = std::make_unique<TestModel>();
462-
::upb::Arena arena;
458+
hpb::Arena arena;
463459
auto bytes = ::hpb::Serialize(model.get(), arena);
464460
EXPECT_TRUE(::hpb::Parse(model.get(), bytes.value()));
465461
}

0 commit comments

Comments
 (0)