Skip to content

Commit 0b016da

Browse files
Merge pull request #423 from protofire/release/3-4-1
New release: 3.4.1
2 parents 02fe5cb + 853b8b7 commit 0b016da

File tree

6 files changed

+51
-5129
lines changed

6 files changed

+51
-5129
lines changed

CHANGELOG.md

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,22 @@
1+
## [3.4.1] - 2023-03-06
2+
### Updated
3+
- Updated solidity parser to 0.16.0 [#420](https://github.com/protofire/solhint/pull/420)
4+
5+
### Added
6+
- Added github workflow to execute unit tests on each PR [#412](https://github.com/protofire/solhint/pull/412)
7+
- Added macOS and windows into E2E github workflow [#422](https://github.com/protofire/solhint/pull/422)
8+
9+
### Fixed
10+
- False positive on for-loop Yul [#400](https://github.com/protofire/solhint/pull/400)
11+
- Ordering-rule support for Top Level statements [#393](https://github.com/protofire/solhint/pull/393)
12+
- Fix no-global-import to accept named global imports [#416](https://github.com/protofire/solhint/pull/416)
13+
- Fix named-parameters-mapping to not enforce on nested mappings [#421](https://github.com/protofire/solhint/pull/421)
14+
15+
16+
17+
18+
19+
<br><br>
120
## [3.4.0] - 2023-02-17
221
### Updated
322
- Solhint dependencies to support newer versions [#380](https://github.com/protofire/solhint/pull/380)
@@ -34,7 +53,7 @@
3453

3554

3655
### Updated
37-
- Solidity Parser to 0.14.5 [#378](https://github.com/protofire/solhint/pull/378)
56+
- Solidity Parser to 0.14.5 [#330](https://github.com/protofire/solhint/pull/330) - [#378](https://github.com/protofire/solhint/pull/378)
3857

3958

4059
<br><br>

README.md

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,11 @@
55
By <a href="https://protofire.io/">Protofire</a>
66
</p>
77

8-
[![Donate with Ethereum](https://en.cryptobadges.io/badge/micro/0xe8cdf02efd8ab0a490d7b2cb13553389c9bc932e)](https://en.cryptobadges.io/donate/0xe8cdf02efd8ab0a490d7b2cb13553389c9bc932e)
9-
10-
[![Gitter chat](https://badges.gitter.im/gitterHQ/gitter.svg)](https://gitter.im/solhint/Lobby)
8+
[![Donate with Ethereum](https://img.shields.io/badge/Donate-ETH-blue)](https://etherscan.io/address/0xA81705c8C247C413a19A244938ae7f4A0393944e)
119
[![NPM version](https://badge.fury.io/js/solhint.svg)](https://npmjs.org/package/solhint)
1210
[![Coverage Status](https://coveralls.io/repos/github/protofire/solhint/badge.svg?branch=master)](
1311
https://coveralls.io/github/protofire/solhint?branch=master)
1412
[![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](https://raw.githubusercontent.com/protofire/solhint/master/LICENSE)
15-
[![dependencies Status](https://david-dm.org/protofire/solhint/status.svg)](https://david-dm.org/protofire/solhint)
16-
[![devDependencies Status](https://david-dm.org/protofire/solhint/dev-status.svg)](https://david-dm.org/protofire/solhint?type=dev)
1713

1814
This is an open source project for linting [Solidity](http://solidity.readthedocs.io/en/develop/) code. This project
1915
provides both **Security** and **Style Guide** validations.
@@ -83,10 +79,15 @@ To generate a new sample `.solhint.json` file in current folder you can do:
8379
solhint --init
8480
```
8581

86-
This file has the following
87-
format:
88-
82+
This file has the following format:
83+
### Default
84+
```json
85+
{
86+
"extends": "solhint:default"
87+
}
88+
```
8989

90+
### Sample
9091
```json
9192
{
9293
"extends": "solhint:recommended",
@@ -214,7 +215,8 @@ Related documentation you may find [here](https://protofire.github.io/solhint/).
214215
- POA Network - Public EVM Sidechain:
215216
- [Proof of Physical Address (PoPA)](https://github.com/poanetwork/poa-popa)
216217
- [Proof of Bank Account (PoBA)](https://github.com/poanetwork/poa-poba)
217-
- [0x](https://github.com/0xProject/0x-monorepo/tree/development/contracts)
218+
- 0x-Project
219+
- [0x-Monorepo](https://github.com/0xProject/0x-monorepo/tree/development/contracts)
218220
- Gnosis:
219221
- [Gnosis Prediction Market Contracts](https://github.com/gnosis/pm-contracts)
220222
- [The DutchX decentralized trading protocol](https://github.com/gnosis/dex-contracts)
@@ -230,7 +232,7 @@ MIT
230232
## Back us
231233
Solhint is free to use and open-sourced. If you value our effort and feel like helping us to keep pushing this tool forward, you can send us a small donation. We'll highly appreciate it :)
232234

233-
[![Donate with Ethereum](https://en.cryptobadges.io/badge/micro/0xe8cdf02efd8ab0a490d7b2cb13553389c9bc932e)](https://en.cryptobadges.io/donate/0xe8cdf02efd8ab0a490d7b2cb13553389c9bc932e)
235+
[![Donate with Ethereum](https://img.shields.io/badge/Donate-ETH-blue)](https://etherscan.io/address/0xA81705c8C247C413a19A244938ae7f4A0393944e)
234236

235237
## Related projects
236238

docs/rules/best-practises/no-console.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ import "forge-std/consoleN.sol"
5151
```
5252

5353
## Version
54-
This rule is introduced in the latest version.
54+
This rule was introduced in [Solhint 3.4.0](https://github.com/protofire/solhint/tree/v3.4.0)
5555

5656
## Resources
5757
- [Rule source](https://github.com/protofire/solhint/tree/master/lib/rules/best-practises/no-console.js)

docs/rules/best-practises/no-global-import.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,18 @@ This rule accepts a string option of rule severity. Must be one of "error", "war
3636
import {A} from "./A.sol"
3737
```
3838

39+
#### import entire file into a name
40+
41+
```solidity
42+
import "./A.sol" as A
43+
```
44+
45+
#### import entire file into a name
46+
47+
```solidity
48+
import * as A from "./A.sol"
49+
```
50+
3951
### 👎 Examples of **incorrect** code for this rule
4052

4153
#### import all members from a file
@@ -51,7 +63,7 @@ import "foo.sol"
5163
```
5264

5365
## Version
54-
This rule is introduced in the latest version.
66+
This rule was introduced in [Solhint 3.4.0](https://github.com/protofire/solhint/tree/v3.4.0)
5567

5668
## Resources
5769
- [Rule source](https://github.com/protofire/solhint/tree/master/lib/rules/best-practises/no-global-import.js)

0 commit comments

Comments
 (0)