Merge pull request #702 from protofire/fix/minor-issues

fix: minor issues

Author: dbale-altoros

docs/rules.md

@@ -45,7 +45,7 @@ title:       "Rule Index of Solhint"
 | [use-forbidden-name](./rules/naming/use-forbidden-name.md)                           | Avoid to use letters 'I', 'l', 'O' as identifiers.                                                            | $~~~~~~~~$✔️ |            |
 | [var-name-mixedcase](./rules/naming/var-name-mixedcase.md)                           | Variable names must be in mixedCase. (Does not check IMMUTABLES nor CONSTANTS (use inherent rules for that)   | $~~~~~~~~$✔️ |            |
 | [imports-on-top](./rules/order/imports-on-top.md)                                    | Import statements must be on top.                                                                             | $~~~~~~~~$✔️ |            |
-| [imports-order](./rules/naming/imports-order.md)                                     | Order the imports of the contract to follow a certain hierarchy (read "Notes section")                        |              |            |
+| [imports-order](./rules/order/imports-order.md)                                      | Order the imports of the contract to follow a certain hierarchy (read "Notes section")                        |              |            |
 | [ordering](./rules/order/ordering.md)                                                | Check order of elements in file and inside each contract, according to the style guide                        |              |            |
 | [visibility-modifier-order](./rules/order/visibility-modifier-order.md)              | Visibility modifier must be first in list of modifiers.                                                       | $~~~~~~~~$✔️ |            |
         

docs/rules/best-practices/use-natspec.md

@@ -133,7 +133,7 @@ This rule accepts an array of options:
 ```
 
 ## Version
-This rule was introduced in the latest version.
+This rule was introduced in [Solhint 6.0.0](https://github.com/protofire/solhint/blob/v6.0.0)
 
 ## Resources
 - [Rule source](https://github.com/protofire/solhint/blob/master/lib/rules/best-practices/use-natspec.js)

docs/rules/miscellaneous/quotes.md

@@ -36,7 +36,7 @@ This rule accepts an array of options:
 ```
 
 ### Notes
-- This rule allows to put a double quote inside single quote string and viceversa
+- This rule allows to put a double quote inside single quote string and vice versa
 
 ## Examples
 ### 👍 Examples of **correct** code for this rule

docs/rules/naming/imports-order.md docs/rules/order/imports-order.mddocs/rules/naming/imports-order.md renamed to docs/rules/order/imports-order.md

@@ -84,7 +84,7 @@ class ExplicitTypesChecker extends BaseChecker {
       (config && config.getStringFromArray(ruleId, DEFAULT_OPTION)) || DEFAULT_OPTION
     this.isExplicit = this.configOption === 'explicit'
 
-    // if explicit, it will search for implicit and viceversa
+    // if explicit, it will search for implicit and vice versa
     if (this.isExplicit) {
       typesToSearch = IMPLICIT_TYPES
     } else {

lib/rules/best-practices/explicit-types.js

@@ -56,7 +56,7 @@ const meta = {
     },
     notes: [
       {
-        note: 'This rule allows to put a double quote inside single quote string and viceversa',
+        note: 'This rule allows to put a double quote inside single quote string and vice versa',
       },
     ],
   },

lib/rules/miscellaneous/quotes.js

@@ -5,7 +5,7 @@ const DEFAULT_SEVERITY = 'warn'
 
 const ruleId = 'imports-order'
 const meta = {
-  type: 'naming',
+  type: 'order',
 
   docs: {
     description: `Order the imports of the contract to follow a certain hierarchy (read "Notes section")`,

lib/rules/order/imports-order.js

@@ -1,6 +1,6 @@
 {
   "name": "solhint",
-  "version": "6.0.0",
+  "version": "6.0.1",
   "description": "Solidity Code Linter",
   "main": "lib/index.js",
   "keywords": [

package.json

@@ -0,0 +1,3 @@
+// No unit tests for this rule
+// Test are done as E2E
+// e2e/autofix-test.js ==> autofix rule: imports-order

test/fixtures/order/imports-order.js

@@ -92,7 +92,7 @@ describe('Linter - quotes', () => {
     assertErrorCount(reports[0], 1)
   })
 
-  describe('Double quotes inside single and viceversa', () => {
+  describe('Double quotes inside single and vice versa', () => {
     it('should not raise error when configured as single and there are double quotes inside', function test() {
       const code = contractWith('string private constant STR = \'You shall "pass" !\';')