Executing 'render test' requires building subpackage first

[pietervdvn]

Hi,

From a clean install, I did:

cd render-tests
npm ci
npm run build
npm run test

which gave me the following output:

> render-test@1.0.0 test
> node dist/run_render_tests.js

node:internal/modules/esm/resolve:265
    throw new ERR_MODULE_NOT_FOUND(
          ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/pietervdvn/git/basemaps/render-tests/node_modules/@protomaps/basemaps/dist/esm/index.js' imported from /home/pietervdvn/git/basemaps/render-tests/dist/run_render_tests.js
    at finalizeResolution (node:internal/modules/esm/resolve:265:11)
    at moduleResolve (node:internal/modules/esm/resolve:933:10)
    at defaultResolve (node:internal/modules/esm/resolve:1169:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:227:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)
    at link (node:internal/modules/esm/module_job:86:36) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///home/pietervdvn/git/basemaps/render-tests/node_modules/@protomaps/basemaps/dist/esm/index.js'
}

Node.js v20.16.0

So I did:

cd node_modules/@protomaps/basemaps
npm ci
npm run build

after which the tests worked as expected. IMHO, building the subpackage should not be needed and is an extra barrier to new contributors.

[bdon]

npm run build

without changing this project into a monorepo, the sensible thing may be to make npm run build in the render-tests directory also build the sibling basemaps package.

[pietervdvn]

Yeah, indeed; this can be done by adding a postinstall in the scripts section, that is executed after every npm i and can be used to build packages