Skip to content

Issue-2555: add placeholders #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Issue-2555: add placeholders #2836

wants to merge 6 commits into from

Conversation

vitalymatyushik
Copy link
Contributor

@vitalymatyushik vitalymatyushik commented Oct 27, 2022 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances) No

What changes did you make? Make placeholders visible in inputs on Topic Creation page when they are empty

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@vitalymatyushik vitalymatyushik requested a review from a team as a code owner October 27, 2022 20:48
@vitalymatyushik
Copy link
Contributor Author

@Haarolean I've checked react-hook-form api and didn't found fast way to implement the change for the following screen
image
maybe you can suggest the way how to achieve it or propose different change?

@Haarolean Haarolean linked an issue Oct 28, 2022 that may be closed by this pull request
Add placeholders for "Time to retain data (in ms)" ,"Maximum message size in bytes *" fields within Create Topic #2555
Open
@Haarolean
Copy link
Contributor

@Haarolean I've checked react-hook-form api and didn't found fast way to implement the change for the following screen image maybe you can suggest the way how to achieve it or propose different change?

@provectus/kafka-frontend please help

@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/frontend labels Nov 1, 2022
@Haarolean Haarolean self-assigned this Nov 1, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Mgrdich
Copy link
Contributor

Mgrdich commented Nov 2, 2022 •
edited
Loading

@Haarolean I've checked react-hook-form api and didn't found fast way to implement the change for the following screen image maybe you can suggest the way how to achieve it or propose different change?

@provectus/kafka-frontend please help

@vitalymatyushik
https://stackoverflow.com/questions/43964528/append-uneditable-text-to-end-of-input .
I think we can try more of a css like solution , we can create a component for this or even do a custom code for this one where you can actually set the (7 days) etc in the input or div attribute and with a pseudo element , and we can get the that attribute value with css and put it with pseudo element as mentioned above.

@Haarolean
Copy link
Contributor

@vitalymatyushik and this one?

@Haarolean Haarolean added the status/pending Further information is requested label Dec 7, 2022
@Haarolean Haarolean marked this pull request as draft December 12, 2022 15:52
@github-actions
Copy link

This PR has been automatically marked as stale because no requested changes have been applied. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the status/stale Stale issues will be closed in 7 days. label Dec 20, 2022
@github-actions github-actions bot closed this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vitalymatyushik vitalymatyushik

Labels
hacktoberfest-accepted scope/frontend status/pending Further information is requested status/stale Stale issues will be closed in 7 days. type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
No milestone
3 participants
@vitalymatyushik @Haarolean @Mgrdich