fix(googleworkspace): use per-service resources

Author: lydiavilchez

prowler/providers/googleworkspace/services/chat/chat_apps_installation_disabled/chat_apps_installation_disabled.py

@@ -18,7 +18,10 @@ def execute(self) -> List[CheckReportGoogleWorkspace]:
         if chat_client.policies_fetched:
             report = CheckReportGoogleWorkspace(
                 metadata=self.metadata(),
-                resource=chat_client.provider.domain_resource,
+                resource=chat_client.policies,
+                resource_id="chatPolicies",
+                resource_name="Chat Policies",
+                customer_id=chat_client.provider.identity.customer_id,
             )
 
             apps_enabled = chat_client.policies.enable_apps

prowler/providers/googleworkspace/services/chat/chat_external_file_sharing_disabled/chat_external_file_sharing_disabled.py

@@ -18,7 +18,10 @@ def execute(self) -> List[CheckReportGoogleWorkspace]:
         if chat_client.policies_fetched:
             report = CheckReportGoogleWorkspace(
                 metadata=self.metadata(),
-                resource=chat_client.provider.domain_resource,
+                resource=chat_client.policies,
+                resource_id="chatPolicies",
+                resource_name="Chat Policies",
+                customer_id=chat_client.provider.identity.customer_id,
             )
 
             external_sharing = chat_client.policies.external_file_sharing

prowler/providers/googleworkspace/services/chat/chat_external_messaging_restricted/chat_external_messaging_restricted.py

@@ -18,7 +18,10 @@ def execute(self) -> List[CheckReportGoogleWorkspace]:
         if chat_client.policies_fetched:
             report = CheckReportGoogleWorkspace(
                 metadata=self.metadata(),
-                resource=chat_client.provider.domain_resource,
+                resource=chat_client.policies,
+                resource_id="chatPolicies",
+                resource_name="Chat Policies",
+                customer_id=chat_client.provider.identity.customer_id,
             )
 
             allow_external = chat_client.policies.allow_external_chat

prowler/providers/googleworkspace/services/chat/chat_external_spaces_restricted/chat_external_spaces_restricted.py

@@ -18,7 +18,10 @@ def execute(self) -> List[CheckReportGoogleWorkspace]:
         if chat_client.policies_fetched:
             report = CheckReportGoogleWorkspace(
                 metadata=self.metadata(),
-                resource=chat_client.provider.domain_resource,
+                resource=chat_client.policies,
+                resource_id="chatPolicies",
+                resource_name="Chat Policies",
+                customer_id=chat_client.provider.identity.customer_id,
             )
 
             spaces_enabled = chat_client.policies.external_spaces_enabled

prowler/providers/googleworkspace/services/chat/chat_incoming_webhooks_disabled/chat_incoming_webhooks_disabled.py

@@ -18,7 +18,10 @@ def execute(self) -> List[CheckReportGoogleWorkspace]:
         if chat_client.policies_fetched:
             report = CheckReportGoogleWorkspace(
                 metadata=self.metadata(),
-                resource=chat_client.provider.domain_resource,
+                resource=chat_client.policies,
+                resource_id="chatPolicies",
+                resource_name="Chat Policies",
+                customer_id=chat_client.provider.identity.customer_id,
             )
 
             webhooks_enabled = chat_client.policies.enable_webhooks

prowler/providers/googleworkspace/services/chat/chat_internal_file_sharing_disabled/chat_internal_file_sharing_disabled.py

@@ -18,7 +18,10 @@ def execute(self) -> List[CheckReportGoogleWorkspace]:
         if chat_client.policies_fetched:
             report = CheckReportGoogleWorkspace(
                 metadata=self.metadata(),
-                resource=chat_client.provider.domain_resource,
+                resource=chat_client.policies,
+                resource_id="chatPolicies",
+                resource_name="Chat Policies",
+                customer_id=chat_client.provider.identity.customer_id,
             )
 
             internal_sharing = chat_client.policies.internal_file_sharing

tests/providers/googleworkspace/services/chat/chat_apps_installation_disabled/chat_apps_installation_disabled_test.py

@@ -3,7 +3,6 @@
 from prowler.providers.googleworkspace.services.chat.chat_service import ChatPolicies
 from tests.providers.googleworkspace.googleworkspace_fixtures import (
     CUSTOMER_ID,
-    DOMAIN,
     set_mocked_googleworkspace_provider,
 )
 
@@ -35,10 +34,10 @@ def test_pass(self):
             assert len(findings) == 1
             assert findings[0].status == "PASS"
             assert "disabled" in findings[0].status_extended
-            assert findings[0].resource_name == DOMAIN
-            assert findings[0].resource_id == CUSTOMER_ID
+            assert findings[0].resource_name == "Chat Policies"
+            assert findings[0].resource_id == "chatPolicies"
             assert findings[0].customer_id == CUSTOMER_ID
-            assert findings[0].resource == mock_provider.domain_resource.dict()
+            assert findings[0].resource == ChatPolicies(enable_apps=False).dict()
 
     def test_fail_enabled(self):
         mock_provider = set_mocked_googleworkspace_provider()

tests/providers/googleworkspace/services/chat/chat_external_file_sharing_disabled/chat_external_file_sharing_disabled_test.py

@@ -3,7 +3,6 @@
 from prowler.providers.googleworkspace.services.chat.chat_service import ChatPolicies
 from tests.providers.googleworkspace.googleworkspace_fixtures import (
     CUSTOMER_ID,
-    DOMAIN,
     set_mocked_googleworkspace_provider,
 )
 
@@ -35,10 +34,13 @@ def test_pass(self):
             assert len(findings) == 1
             assert findings[0].status == "PASS"
             assert "disabled" in findings[0].status_extended
-            assert findings[0].resource_name == DOMAIN
-            assert findings[0].resource_id == CUSTOMER_ID
+            assert findings[0].resource_name == "Chat Policies"
+            assert findings[0].resource_id == "chatPolicies"
             assert findings[0].customer_id == CUSTOMER_ID
-            assert findings[0].resource == mock_provider.domain_resource.dict()
+            assert (
+                findings[0].resource
+                == ChatPolicies(external_file_sharing="NO_FILES").dict()
+            )
 
     def test_fail_all_files(self):
         mock_provider = set_mocked_googleworkspace_provider()

tests/providers/googleworkspace/services/chat/chat_external_messaging_restricted/chat_external_messaging_restricted_test.py

@@ -3,7 +3,6 @@
 from prowler.providers.googleworkspace.services.chat.chat_service import ChatPolicies
 from tests.providers.googleworkspace.googleworkspace_fixtures import (
     CUSTOMER_ID,
-    DOMAIN,
     set_mocked_googleworkspace_provider,
 )
 
@@ -35,10 +34,12 @@ def test_pass_external_chat_disabled(self):
             assert len(findings) == 1
             assert findings[0].status == "PASS"
             assert "disabled" in findings[0].status_extended
-            assert findings[0].resource_name == DOMAIN
-            assert findings[0].resource_id == CUSTOMER_ID
+            assert findings[0].resource_name == "Chat Policies"
+            assert findings[0].resource_id == "chatPolicies"
             assert findings[0].customer_id == CUSTOMER_ID
-            assert findings[0].resource == mock_provider.domain_resource.dict()
+            assert (
+                findings[0].resource == ChatPolicies(allow_external_chat=False).dict()
+            )
 
     def test_pass_trusted_domains(self):
         mock_provider = set_mocked_googleworkspace_provider()

tests/providers/googleworkspace/services/chat/chat_external_spaces_restricted/chat_external_spaces_restricted_test.py

@@ -3,7 +3,6 @@
 from prowler.providers.googleworkspace.services.chat.chat_service import ChatPolicies
 from tests.providers.googleworkspace.googleworkspace_fixtures import (
     CUSTOMER_ID,
-    DOMAIN,
     set_mocked_googleworkspace_provider,
 )
 
@@ -35,10 +34,13 @@ def test_pass_spaces_disabled(self):
             assert len(findings) == 1
             assert findings[0].status == "PASS"
             assert "disabled" in findings[0].status_extended
-            assert findings[0].resource_name == DOMAIN
-            assert findings[0].resource_id == CUSTOMER_ID
+            assert findings[0].resource_name == "Chat Policies"
+            assert findings[0].resource_id == "chatPolicies"
             assert findings[0].customer_id == CUSTOMER_ID
-            assert findings[0].resource == mock_provider.domain_resource.dict()
+            assert (
+                findings[0].resource
+                == ChatPolicies(external_spaces_enabled=False).dict()
+            )
 
     def test_pass_trusted_domains(self):
         mock_provider = set_mocked_googleworkspace_provider()