From 648b349e50cbdd62a0cafed09d829cbf8784a009 Mon Sep 17 00:00:00 2001 From: Hugo Pereira Brito <101209179+HugoPBrito@users.noreply.github.com> Date: Mon, 4 May 2026 11:17:54 +0100 Subject: [PATCH] fix(ui): clean up findings expanded resource row layout (#10949) (cherry picked from commit 6cb770fcc8d7579dff689e07276752a0db3316c0) --- ui/CHANGELOG.md | 8 ++ .../table/column-finding-resources.tsx | 78 +++++++++---------- .../table/inline-resource-container.tsx | 38 ++++----- 3 files changed, 62 insertions(+), 62 deletions(-) diff --git a/ui/CHANGELOG.md b/ui/CHANGELOG.md index dd6daa3969d..53af0c030f0 100644 --- a/ui/CHANGELOG.md +++ b/ui/CHANGELOG.md @@ -2,6 +2,14 @@ All notable changes to the **Prowler UI** are documented in this file. +## [1.26.0] (Prowler UNRELEASED) + +### 🔄 Changed + +- Findings expanded resource rows now drop the redundant cube icons, render Service and Region with the same compact label style as Last seen and Failing for, and reorder columns to Status, Resource, Provider, Severity, then field labels [(#10949)](https://github.com/prowler-cloud/prowler/pull/10949) + +--- + ## [1.25.1] (Prowler v5.25.1) ### 🐞 Fixed diff --git a/ui/components/findings/table/column-finding-resources.tsx b/ui/components/findings/table/column-finding-resources.tsx index 4b184459ef0..5789b8a96bf 100644 --- a/ui/components/findings/table/column-finding-resources.tsx +++ b/ui/components/findings/table/column-finding-resources.tsx @@ -1,7 +1,7 @@ "use client"; import { ColumnDef, Row, RowSelectionState } from "@tanstack/react-table"; -import { Container, CornerDownRight, VolumeOff, VolumeX } from "lucide-react"; +import { CornerDownRight, VolumeOff, VolumeX } from "lucide-react"; import { useContext, useState } from "react"; import { MuteFindingsModal } from "@/components/findings/mute-findings-modal"; @@ -203,23 +203,6 @@ export function getColumnFindingResources({ enableSorting: false, enableHiding: false, }, - // Resource — name + uid (EntityInfo with resource icon) - { - id: "resource", - header: ({ column }) => ( - - ), - cell: ({ row }) => ( -
- } - entityAlias={row.original.resourceName} - entityId={row.original.resourceUid} - /> -
- ), - enableSorting: false, - }, // Status { id: "status", @@ -233,29 +216,35 @@ export function getColumnFindingResources({ }, enableSorting: false, }, - // Service + // Resource — name + uid { - id: "service", + id: "resource", header: ({ column }) => ( - + ), cell: ({ row }) => ( -

- {row.original.service} -

+
+ +
), enableSorting: false, }, - // Region + // Provider — alias + uid (same style as Resource) { - id: "region", + id: "provider", header: ({ column }) => ( - + ), cell: ({ row }) => ( -

- {row.original.region} -

+
+ +
), enableSorting: false, }, @@ -268,20 +257,29 @@ export function getColumnFindingResources({ cell: ({ row }) => , enableSorting: false, }, - // Account — alias + uid (EntityInfo with provider logo) + // Service { - id: "account", + id: "service", header: ({ column }) => ( - + ), cell: ({ row }) => ( -
- -
+ + {row.original.service || "-"} + + ), + enableSorting: false, + }, + // Region + { + id: "region", + header: ({ column }) => ( + + ), + cell: ({ row }) => ( + + {row.original.region || "-"} + ), enableSorting: false, }, diff --git a/ui/components/findings/table/inline-resource-container.tsx b/ui/components/findings/table/inline-resource-container.tsx index 2aa13056d92..22ccb027e1b 100644 --- a/ui/components/findings/table/inline-resource-container.tsx +++ b/ui/components/findings/table/inline-resource-container.tsx @@ -70,27 +70,23 @@ function ResourceSkeletonRow({
- {/* Resource: icon + name + uid */} - -
- -
- - -
-
-
{/* Status */} - {/* Service */} + {/* Resource: name + uid */} - +
+ + +
- {/* Region */} + {/* Provider: alias + uid */} - +
+ + +
{/* Severity */} @@ -99,15 +95,13 @@ function ResourceSkeletonRow({ - {/* Account: provider icon + alias + uid */} + {/* Service */} -
- -
- - -
-
+ +
+ {/* Region */} + + {/* Last seen */}