violations_coverage; unsafe_method impl

Author: peter-lyons-kehl

src/linted.rs

@@ -214,7 +214,7 @@ macro_rules! internal_prudent_unsafe_method {
                     // We **cannot** just move/take/assign $self by value, in case it's a non-Copy
                     // **static** variable. See also comments in
                     // unsafe_method_internal_build_accessors_check_args_call.
-                    let rref = {
+                    let mref = {
                         #[rustfmt::skip]
                         #[deny(unused_unsafe)]
                         // @TODO simplify once https://github.com/rust-lang/rust/issues/15701
@@ -230,10 +230,8 @@ macro_rules! internal_prudent_unsafe_method {
                             #[expect(unsafe_code)]
                         )?
                         let rref = &( $self );
-                        rref
+                        ::prudent::unlinted::shared_to_mut( rref )
                     };
-                    //
-                    let mref = ::prudent::unlinted::shared_to_mut(rref);
                     #[allow(unused_mut)]
                     #[allow(invalid_value)]
                     let mut owned_receiver = ::core::mem::replace(mref, unsafe{ ::core::mem::zeroed() });

src/linted_with_tests.rs

@@ -56,6 +56,7 @@ pub use crate::linted_untested::PRUDENT_INTERNAL_LINTED_VERSION;
 /// ```
 /// test cfg test:
 /// ```test_harness
+/// // test_harness -as per https://github.com/rust-lang/rust/issues/148942#issuecomment-3565011334
 /// #[cfg(not(test))]
 /// compile_error!("NOT DOCTEST!");
 /// ```
@@ -195,13 +196,13 @@ pub use crate::linted_untested::internal_prudent_unsafe_method;
 pub const _: () = {};
 
 /// ```compile_fail,E0133
-#[doc = include_str!("../violations_coverage/unsafe_method/sneaked_unsafe/self_some_args.rs")]
+#[doc = include_str!("../violations_coverage/unsafe_method/sneaked_unsafe/self_zero_args.rs")]
 /// ```
 #[cfg(doctest)]
 pub const _: () = {};
 
 /// ```compile_fail,E0133
-#[doc = include_str!("../violations_coverage/unsafe_method/sneaked_unsafe/self_zero_args.rs")]
+#[doc = include_str!("../violations_coverage/unsafe_method/sneaked_unsafe/self_some_args.rs")]
 /// ```
 #[cfg(doctest)]
 pub const _: () = {};

src/unlinted.rs

@@ -316,7 +316,7 @@ macro_rules! allow_unsafe_expect_unsafe_is_correct {
 /// NOT a part of public API. Pretend to get a mutable reference from a shared reference. For
 /// internal/generated **compile-time** checks only.
 #[doc(hidden)]
-pub const fn shared_to_mut<T>(_: &T) -> &mut T {
+pub const fn shared_to_mut<T>(_: &T) -> &'static mut T {
     unreachable!()
 }
 

violations_coverage/unsafe_method/sneaked_unsafe/self_zero_args.rs

@@ -8,7 +8,7 @@ impl S {
 }
 
 unsafe fn new_receiver() -> S {
-    unreachable!();
+    unreachable!()
 }
 
 fn main() {