Changing linter

perki · perki · commit 877ef72f1839 · 2026-02-03T18:57:23.000+01:00
diff --git a/components/pryv-monitor/src/UpdateMethod/Socket.js b/components/pryv-monitor/src/UpdateMethod/Socket.js
@@ -21,8 +21,7 @@ class Socket extends UpdateMethod {
     this.socket = await this.monitor.connection.socket.open();
     this.socket.on('eventsChanged', () => { this.monitor.updateEvents(); });
     this.socket.on('streamsChanged', () => { this.monitor.updateStreams(); });
-    /* eslint-disable-next-line node/handle-callback-err */
-    this.socket.on('error', (error) => { this.monitor.emit(Changes.ERROR.error); });
+    this.socket.on('error', (error) => { this.monitor.emit(Changes.ERROR, error); });
   }
 
   async stop () {
diff --git a/components/pryv-monitor/test/load-helpers.js b/components/pryv-monitor/test/load-helpers.js
@@ -3,7 +3,6 @@
  * [BSD-3-Clause](https://github.com/pryv/lib-js/blob/master/LICENSE)
  */
 /* global expect, pryv, testData */
-/* eslint-disable no-unused-expressions */
 
 require('../src')(pryv);
 const testStreamId = global.testStreamId = 'monitor-test';
diff --git a/components/pryv-monitor/test/monitor.test.js b/components/pryv-monitor/test/monitor.test.js
@@ -28,8 +28,7 @@ describe('Monitor', function () {
     it('throw Error on invalid apiEndpoint', async () => {
       let passed = true;
       try {
-        /* eslint-disable-next-line no-unused-vars */
-        const monitor = new pryv.Monitor('BlipBlop', { limit: 1 });
+        pryv.Monitor('BlipBlop', { limit: 1 });
         passed = false;
       } catch (e) {
 
diff --git a/components/pryv-socket.io/test/socket.io.test.js b/components/pryv-socket.io/test/socket.io.test.js
@@ -3,7 +3,6 @@
  * [BSD-3-Clause](https://github.com/pryv/lib-js/blob/master/LICENSE)
  */
 /* global describe, it, before, after, beforeEach, afterEach, expect, pryv, testData */
-/* eslint-disable no-unused-expressions */
 
 const cuid = require('cuid');
 
diff --git a/components/pryv/src/Connection.js b/components/pryv/src/Connection.js
@@ -311,8 +311,8 @@ class Connection {
   async addPointsToHFEvent (eventId, fields, points) {
     const res = await this.post('events/' + eventId + '/series', {
       format: 'flatJSON',
-      fields: fields,
-      points: points
+      fields,
+      points
     });
     if (!res.status === 'ok') {
       throw new Error('Failed loading serie: ' + JSON.stringify(res.status));
diff --git a/components/pryv/src/Service.js b/components/pryv/src/Service.js
@@ -153,7 +153,7 @@ class Service {
    */
   static buildAPIEndpoint (serviceInfo, username, token) {
     const endpoint = serviceInfo.api.replace('{username}', username);
-    return utils.buildAPIEndpoint({ endpoint: endpoint, token: token });
+    return utils.buildAPIEndpoint({ endpoint, token });
   }
 
   /**
diff --git a/components/pryv/test/Browser.AuthController.test.js b/components/pryv/test/Browser.AuthController.test.js
@@ -3,7 +3,6 @@
  * [BSD-3-Clause](https://github.com/pryv/lib-js/blob/master/LICENSE)
  */
 /* global describe, it, before, after, expect, testData, JSDOM */
-/* eslint-disable no-unused-expressions */
 
 const utils = require('../src/utils.js');
 const Service = require('../src/Service');
diff --git a/components/pryv/test/Browser.test.js b/components/pryv/test/Browser.test.js
@@ -3,7 +3,6 @@
  * [BSD-3-Clause](https://github.com/pryv/lib-js/blob/master/LICENSE)
  */
 /* global describe, it, before, after, expect, JSDOM, pryv, testData */
-/* eslint-disable no-unused-expressions */
 
 function genSettings () {
   function defaultStateChange (state) {
diff --git a/components/pryv/test/Connection.test.js b/components/pryv/test/Connection.test.js
@@ -3,7 +3,6 @@
  * [BSD-3-Clause](https://github.com/pryv/lib-js/blob/master/LICENSE)
  */
 /* global describe, it, before, after, beforeEach, afterEach, expect, JSDOM, pryv, Blob, FormData */
-/* eslint-disable no-unused-expressions */
 
 // URL and URLSearchParams are native in Node.js and browsers
 const cuid = require('cuid');
diff --git a/components/pryv/test/Service.test.js b/components/pryv/test/Service.test.js
@@ -3,7 +3,6 @@
  * [BSD-3-Clause](https://github.com/pryv/lib-js/blob/master/LICENSE)
  */
 /* global describe, it, before, expect, pryv, testData */
-/* eslint-disable no-unused-expressions */
 
 describe('Service', function () {
   before(async function () {
diff --git a/components/pryv/test/utils.test.js b/components/pryv/test/utils.test.js
@@ -3,7 +3,6 @@
  * [BSD-3-Clause](https://github.com/pryv/lib-js/blob/master/LICENSE)
  */
 /* global describe, it, before, expect, pryv, testData */
-/* eslint-disable no-unused-expressions */
 
 describe('utils', function () {
   before(async function () {
diff --git a/eslint.config.js b/eslint.config.js
@@ -0,0 +1,279 @@
+/**
+ * ESLint flat config - replaces semistandard with modern tooling
+ * Style: StandardJS with semicolons + TypeScript checks
+ */
+const js = require('@eslint/js');
+const stylistic = require('@stylistic/eslint-plugin');
+const tseslint = require('typescript-eslint');
+const nodePlugin = require('eslint-plugin-n');
+const globals = require('globals');
+
+module.exports = [
+  // Ignore patterns (replaces semistandard.ignore in package.json)
+  {
+    ignores: [
+      'node_modules/**',
+      'dist/**',
+      'coverage/**',
+      'test-browser/**',
+      'components/*/examples/pryv-*.js'
+    ]
+  },
+
+  // Base JS recommended rules
+  js.configs.recommended,
+
+  // TypeScript support
+  ...tseslint.configs.recommended,
+
+  // Main configuration for JS/TS files
+  {
+    files: ['**/*.js', '**/*.ts'],
+    plugins: {
+      '@stylistic': stylistic,
+      'n': nodePlugin
+    },
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: 'commonjs',
+      globals: {
+        ...globals.node,
+        ...globals.browser,
+        ...globals.mocha,
+        fetch: 'readonly',
+        FormData: 'readonly',
+        Blob: 'readonly',
+        URL: 'readonly',
+        URLSearchParams: 'readonly'
+      }
+    },
+    rules: {
+      // ============================================
+      // Stylistic rules (semistandard style)
+      // ============================================
+
+      // Semicolons: REQUIRED (this is what makes it "semi" standard)
+      '@stylistic/semi': ['error', 'always'],
+      '@stylistic/semi-spacing': ['error', { before: false, after: true }],
+
+      // Indentation: 2 spaces
+      '@stylistic/indent': ['error', 2, { SwitchCase: 1 }],
+
+      // Quotes: single quotes
+      '@stylistic/quotes': ['error', 'single', { avoidEscape: true, allowTemplateLiterals: true }],
+
+      // Spacing
+      '@stylistic/space-before-function-paren': ['error', {
+        anonymous: 'always',
+        named: 'always',
+        asyncArrow: 'always'
+      }],
+      '@stylistic/space-before-blocks': ['error', 'always'],
+      '@stylistic/space-in-parens': ['error', 'never'],
+      '@stylistic/space-infix-ops': 'error',
+      '@stylistic/space-unary-ops': ['error', { words: true, nonwords: false }],
+      '@stylistic/keyword-spacing': ['error', { before: true, after: true }],
+      '@stylistic/key-spacing': ['error', { beforeColon: false, afterColon: true }],
+      '@stylistic/comma-spacing': ['error', { before: false, after: true }],
+      '@stylistic/array-bracket-spacing': ['error', 'never'],
+      '@stylistic/object-curly-spacing': ['error', 'always'],
+      '@stylistic/block-spacing': ['error', 'always'],
+      '@stylistic/computed-property-spacing': ['error', 'never'],
+      '@stylistic/func-call-spacing': ['error', 'never'],
+      '@stylistic/template-curly-spacing': ['error', 'never'],
+      '@stylistic/no-whitespace-before-property': 'error',
+
+      // Line breaks and formatting
+      '@stylistic/eol-last': ['error', 'always'],
+      '@stylistic/no-multiple-empty-lines': ['error', { max: 1, maxEOF: 0 }],
+      '@stylistic/no-trailing-spaces': 'error',
+      '@stylistic/linebreak-style': ['error', 'unix'],
+      '@stylistic/padded-blocks': ['error', 'never'],
+
+      // Commas and operators
+      '@stylistic/comma-dangle': ['error', 'never'],
+      '@stylistic/comma-style': ['error', 'last'],
+      '@stylistic/dot-location': ['error', 'property'],
+      '@stylistic/operator-linebreak': ['error', 'after', { overrides: { '?': 'before', ':': 'before' } }],
+
+      // Braces
+      '@stylistic/brace-style': ['error', '1tbs', { allowSingleLine: true }],
+      '@stylistic/curly-newline': 'off',
+
+      // Other stylistic
+      '@stylistic/no-mixed-spaces-and-tabs': 'error',
+      '@stylistic/no-tabs': 'error',
+      '@stylistic/no-multi-spaces': 'error',
+      '@stylistic/arrow-spacing': ['error', { before: true, after: true }],
+      '@stylistic/rest-spread-spacing': ['error', 'never'],
+      '@stylistic/yield-star-spacing': ['error', 'after'],
+      '@stylistic/generator-star-spacing': ['error', { before: false, after: true }],
+      '@stylistic/new-parens': 'error',
+      '@stylistic/wrap-iife': ['error', 'any'],
+      '@stylistic/spaced-comment': ['error', 'always', {
+        line: { markers: ['*package', '!', '/', ',', '='] },
+        block: { balanced: true, markers: ['*package', '!', ',', ':', '::', 'flow-include'], exceptions: ['*'] }
+      }],
+
+      // ============================================
+      // Standard JS rules
+      // ============================================
+
+      // Best practices
+      'accessor-pairs': ['error', { setWithoutGet: true, enforceForClassMembers: true }],
+      'array-callback-return': ['error', { allowImplicit: false, checkForEach: false }],
+      'constructor-super': 'error',
+      'default-case-last': 'error',
+      'eqeqeq': ['error', 'always', { null: 'ignore' }],
+      'new-cap': ['error', { newIsCap: true, capIsNew: false, properties: true }],
+      'no-array-constructor': 'error',
+      'no-async-promise-executor': 'error',
+      'no-caller': 'error',
+      'no-case-declarations': 'error',
+      'no-class-assign': 'error',
+      'no-compare-neg-zero': 'error',
+      'no-cond-assign': 'error',
+      'no-const-assign': 'error',
+      'no-constant-condition': ['error', { checkLoops: false }],
+      'no-control-regex': 'error',
+      'no-debugger': 'error',
+      'no-delete-var': 'error',
+      'no-dupe-args': 'error',
+      'no-dupe-class-members': 'error',
+      'no-dupe-keys': 'error',
+      'no-duplicate-case': 'error',
+      'no-empty': ['error', { allowEmptyCatch: true }],
+      'no-empty-character-class': 'error',
+      'no-empty-pattern': 'error',
+      'no-eval': 'error',
+      'no-ex-assign': 'error',
+      'no-extend-native': 'error',
+      'no-extra-bind': 'error',
+      'no-extra-boolean-cast': 'error',
+      'no-fallthrough': 'error',
+      'no-func-assign': 'error',
+      'no-global-assign': 'error',
+      'no-implied-eval': 'error',
+      'no-import-assign': 'error',
+      'no-invalid-regexp': 'error',
+      'no-irregular-whitespace': 'error',
+      'no-iterator': 'error',
+      'no-labels': ['error', { allowLoop: false, allowSwitch: false }],
+      'no-lone-blocks': 'error',
+      'no-loss-of-precision': 'error',
+      'no-misleading-character-class': 'error',
+      'no-multi-str': 'error',
+      'no-new': 'error',
+      'no-new-func': 'error',
+      'no-new-native-nonconstructor': 'error',
+      'no-new-wrappers': 'error',
+      'no-obj-calls': 'error',
+      'no-object-constructor': 'error',
+      'no-octal': 'error',
+      'no-octal-escape': 'error',
+      'no-proto': 'error',
+      'no-prototype-builtins': 'error',
+      'no-redeclare': ['error', { builtinGlobals: false }],
+      'no-regex-spaces': 'error',
+      'no-return-assign': ['error', 'except-parens'],
+      'no-self-assign': ['error', { props: true }],
+      'no-self-compare': 'error',
+      'no-sequences': 'error',
+      'no-shadow-restricted-names': 'error',
+      'no-sparse-arrays': 'error',
+      'no-template-curly-in-string': 'error',
+      'no-this-before-super': 'error',
+      'no-throw-literal': 'error',
+      'no-undef': 'error',
+      'no-undef-init': 'error',
+      'no-unexpected-multiline': 'error',
+      'no-unmodified-loop-condition': 'error',
+      'no-unneeded-ternary': ['error', { defaultAssignment: false }],
+      'no-unreachable': 'error',
+      'no-unreachable-loop': 'error',
+      'no-unsafe-finally': 'error',
+      'no-unsafe-negation': 'error',
+      'no-unused-expressions': ['error', { allowShortCircuit: true, allowTernary: true, allowTaggedTemplates: true }],
+      // Disable base rule in favor of @typescript-eslint version
+      'no-unused-vars': 'off',
+      'no-use-before-define': ['error', { functions: false, classes: false, variables: false }],
+      'no-useless-backreference': 'error',
+      'no-useless-call': 'error',
+      'no-useless-catch': 'error',
+      'no-useless-computed-key': 'error',
+      'no-useless-constructor': 'error',
+      'no-useless-escape': 'error',
+      'no-useless-rename': 'error',
+      'no-useless-return': 'error',
+      'no-var': 'warn',
+      'no-void': 'error',
+      'no-with': 'error',
+      'object-shorthand': ['warn', 'properties'],
+      'one-var': ['error', { initialized: 'never' }],
+      'prefer-const': ['error', { destructuring: 'all' }],
+      'prefer-promise-reject-errors': 'error',
+      'prefer-regex-literals': ['error', { disallowRedundantWrapping: true }],
+      'symbol-description': 'error',
+      'unicode-bom': ['error', 'never'],
+      'use-isnan': ['error', { enforceForSwitchCase: true, enforceForIndexOf: true }],
+      'valid-typeof': ['error', { requireStringLiterals: true }],
+      'yoda': ['error', 'never'],
+
+      // Node.js specific
+      'n/handle-callback-err': ['error', '^(err|error)$'],
+      'n/no-callback-literal': 'error',
+      'n/no-deprecated-api': 'error',
+      'n/no-exports-assign': 'error',
+      'n/no-new-require': 'error',
+      'n/no-path-concat': 'error',
+      'n/process-exit-as-throw': 'error',
+
+      // ============================================
+      // TypeScript specific rules
+      // ============================================
+      '@typescript-eslint/no-unused-vars': ['error', {
+        args: 'none',
+        caughtErrors: 'none',
+        ignoreRestSiblings: true,
+        varsIgnorePattern: '^_',
+        argsIgnorePattern: '^_'
+      }],
+      '@typescript-eslint/no-require-imports': 'off', // Allow require() in CommonJS
+      '@typescript-eslint/no-explicit-any': 'off', // Allow any for now (existing codebase)
+      '@typescript-eslint/explicit-function-return-type': 'off',
+      '@typescript-eslint/explicit-module-boundary-types': 'off',
+      '@typescript-eslint/ban-ts-comment': 'off'
+    }
+  },
+
+  // TypeScript declaration files - relaxed rules
+  {
+    files: ['**/*.d.ts'],
+    rules: {
+      // Disable all stylistic rules for .d.ts files
+      '@stylistic/space-before-function-paren': 'off',
+      '@stylistic/semi': 'off',
+      '@stylistic/indent': 'off',
+      '@stylistic/no-multiple-empty-lines': 'off',
+      '@stylistic/eol-last': 'off',
+      '@stylistic/no-multi-spaces': 'off',
+      '@stylistic/no-trailing-spaces': 'off',
+      // Disable variable/type checks (types come from imports)
+      'no-undef': 'off',
+      'no-unused-vars': 'off',
+      '@typescript-eslint/no-unused-vars': 'off',
+      '@typescript-eslint/triple-slash-reference': 'off',
+      '@typescript-eslint/no-empty-object-type': 'off',
+      '@typescript-eslint/no-wrapper-object-types': 'off'
+    }
+  },
+
+  // Test files - relaxed rules
+  {
+    files: ['**/test/**/*.js', '**/*.test.js', '**/*.spec.js'],
+    rules: {
+      'no-unused-expressions': 'off',
+      '@typescript-eslint/no-unused-expressions': 'off'
+    }
+  }
+];
diff --git a/justfile b/justfile
@@ -41,7 +41,15 @@ build-watch *params:
 
 # Run code linting
 lint *params:
-    semistandard {{params}}
+    eslint . {{params}}
+
+# Run code linting and fix auto-fixable issues
+lint-fix *params:
+    eslint . --fix {{params}}
+
+# Run TypeScript type checking (no emit)
+typecheck:
+    npx tsc --noEmit -p tsconfig.json
 
 # Run tests on the given component ('all' for all components) with optional extra parameters
 test component *params:
diff --git a/package.json b/package.json
diff --git a/test/test-data.js b/test/test-data.js
diff --git a/tsconfig.json b/tsconfig.json

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,7 @@ class Socket extends UpdateMethod {`
`21`	`21`	`this.socket = await this.monitor.connection.socket.open();`
`22`	`22`	`this.socket.on('eventsChanged', () => { this.monitor.updateEvents(); });`
`23`	`23`	`this.socket.on('streamsChanged', () => { this.monitor.updateStreams(); });`
`24`		`- /* eslint-disable-next-line node/handle-callback-err */`
`25`		`- this.socket.on('error', (error) => { this.monitor.emit(Changes.ERROR.error); });`
	`24`	`+ this.socket.on('error', (error) => { this.monitor.emit(Changes.ERROR, error); });`
`26`	`25`	`}`
`27`	`26`
`28`	`27`	`async stop () {`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ class Service {`
`153`	`153`	`*/`
`154`	`154`	`static buildAPIEndpoint (serviceInfo, username, token) {`
`155`	`155`	`const endpoint = serviceInfo.api.replace('{username}', username);`
`156`		`- return utils.buildAPIEndpoint({ endpoint: endpoint, token: token });`
	`156`	`+ return utils.buildAPIEndpoint({ endpoint, token });`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`/**`