Skip to content

Commit 35cd90c

Browse files
committed
compilation fixes
1 parent 5ab9c31 commit 35cd90c

File tree

3 files changed

+28
-28
lines changed

3 files changed

+28
-28
lines changed

src/xmpp/xmpp-im/xmpp_mammanager.cpp

+18-18
Original file line numberDiff line numberDiff line change
@@ -44,45 +44,45 @@ MAMManager::MAMManager(Client *client, int mamPageSize, int mamMaxMessages, bool
4444
MAMManager::~MAMManager() { delete d; }
4545

4646
// TODO: review the safety of these methods/object lifetimes
47-
MAMTask MAMManager::getFullArchive(const Jid &j, const bool allowMUCArchives)
47+
MAMTask *MAMManager::getFullArchive(const Jid &j, const bool allowMUCArchives)
4848
{
49-
MAMTask task = new MAMTask(d->client->rootTask());
49+
auto task = new MAMTask(d->client->rootTask());
5050

51-
task.get(j, QString(), QString(), allowMUCArchives, d->mamPageSize, d->mamMaxMessages, d->flipPages, d->backwards);
51+
task->get(j, QString(), QString(), allowMUCArchives, d->mamPageSize, d->mamMaxMessages, d->flipPages, d->backwards);
5252
return task;
5353
}
5454

55-
MAMTask MAMManager::getArchiveByIDRange(const Jid &j, const QString &fromID, const QString &toID,
56-
const bool allowMUCArchives)
55+
MAMTask *MAMManager::getArchiveByIDRange(const Jid &j, const QString &fromID, const QString &toID,
56+
const bool allowMUCArchives)
5757
{
58-
MAMTask task = new MAMTask(d->client->rootTask());
58+
auto task = new MAMTask(d->client->rootTask());
5959

60-
task.get(j, fromID, toID, allowMUCArchives, d->mamPageSize, d->mamMaxMessages, d->flipPages, d->backwards);
60+
task->get(j, fromID, toID, allowMUCArchives, d->mamPageSize, d->mamMaxMessages, d->flipPages, d->backwards);
6161
return task;
6262
}
6363

64-
MAMTask MAMManager::getArchiveByTimeRange(const Jid &j, const QDateTime &from, const QDateTime &to,
65-
const bool allowMUCArchives)
64+
MAMTask *MAMManager::getArchiveByTimeRange(const Jid &j, const QDateTime &from, const QDateTime &to,
65+
const bool allowMUCArchives)
6666
{
67-
MAMTask task = new MAMTask(d->client->rootTask());
67+
auto task = new MAMTask(d->client->rootTask());
6868

69-
task.get(j, from, to, allowMUCArchives, d->mamPageSize, d->mamMaxMessages, d->flipPages, d->backwards);
69+
task->get(j, from, to, allowMUCArchives, d->mamPageSize, d->mamMaxMessages, d->flipPages, d->backwards);
7070
return task;
7171
}
7272

73-
MAMTask MAMManager::getLatestMessagesFromArchive(const Jid &j, const QString &fromID, const bool allowMUCArchives,
74-
int amount)
73+
MAMTask *MAMManager::getLatestMessagesFromArchive(const Jid &j, const QString &fromID, const bool allowMUCArchives,
74+
int amount)
7575
{
76-
MAMTask task = new MAMTask(d->client->rootTask());
76+
auto task = new MAMTask(d->client->rootTask());
7777

78-
task.get(j, fromID, QString(), allowMUCArchives, d->mamPageSize, amount, true, true);
78+
task->get(j, fromID, QString(), allowMUCArchives, d->mamPageSize, amount, true, true);
7979
return task;
8080
}
8181

82-
MAMTask MAMManager::getMessagesBeforeID(const Jid &j, const QString &toID, const bool allowMUCArchives, int amount)
82+
MAMTask *MAMManager::getMessagesBeforeID(const Jid &j, const QString &toID, const bool allowMUCArchives, int amount)
8383
{
84-
MAMTask task = new MAMTask(d->client->rootTask());
84+
auto task = new MAMTask(d->client->rootTask());
8585

86-
task.get(j, QString(), toID, allowMUCArchives, d->mamPageSize, amount, true, true);
86+
task->get(j, QString(), toID, allowMUCArchives, d->mamPageSize, amount, true, true);
8787
return task;
8888
}

src/xmpp/xmpp-im/xmpp_mammanager.h

+9-9
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ class MAMManager : public QObject {
3434
bool backwards = true);
3535
~MAMManager();
3636

37-
MAMTask getFullArchive(const Jid &j, const bool allowMUCArchives = true);
38-
MAMTask getArchiveByIDRange(const Jid &j, const QString &fromID, const QString &toID,
39-
const bool allowMUCArchives = true);
40-
MAMTask getArchiveByTimeRange(const Jid &j, const QDateTime &from, const QDateTime &to,
41-
const bool allowMUCArchives = true);
42-
MAMTask getLatestMessagesFromArchive(const Jid &j, const QString &fromID, const bool allowMUCArchives = true,
43-
int amount = 100);
44-
MAMTask getMessagesBeforeID(const Jid &j, const QString &toID, const bool allowMUCArchives = true,
45-
int amount = 100);
37+
MAMTask *getFullArchive(const Jid &j, const bool allowMUCArchives = true);
38+
MAMTask *getArchiveByIDRange(const Jid &j, const QString &fromID, const QString &toID,
39+
const bool allowMUCArchives = true);
40+
MAMTask *getArchiveByTimeRange(const Jid &j, const QDateTime &from, const QDateTime &to,
41+
const bool allowMUCArchives = true);
42+
MAMTask *getLatestMessagesFromArchive(const Jid &j, const QString &fromID, const bool allowMUCArchives = true,
43+
int amount = 100);
44+
MAMTask *getMessagesBeforeID(const Jid &j, const QString &toID, const bool allowMUCArchives = true,
45+
int amount = 100);
4646

4747
private:
4848
class Private;

src/xmpp/xmpp-im/xmpp_mamtask.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class Jid;
3939
class MAMTask : public Task {
4040
Q_OBJECT
4141
public:
42-
MAMTask(Task *);
42+
explicit MAMTask(Task *);
4343
MAMTask(const MAMTask &x);
4444
~MAMTask();
4545

0 commit comments

Comments
 (0)