BUG: --github-pull-requests-closed doesn't seem to work

[bsipocz]

--github-pull-requests-closed returns empty, even though I had my own PRs closed/merged as well as closed/merged other people's PRs both this week and last.

[bsipocz]

Ahh, OK, I see that it assumes that a PR was assigned to someone. However, that is a very strong workflow assumption, and it's not at all how any of the community libraries work in the scientific python ecosystem.

So, now I rephrase and ask for either some documentation clarification, e.g. mentioned 'assigned' in Pull requests closed on github; or have another category for PRs where either the PR or any of its commits are authored by the login person, or have another category where a PR is closed by the login person.

[psss]

@bsipocz, could you please have a look at #311? Does it possibly cover your use case as well?

[bsipocz]

Sorry for the late response, it doesn't seem to solve the problem, I still receive an empty response, though I both authored and reviewed and merged a bunch of PRs:

$ did --since 2025-05-01 --github-pull-requests-closed
Status report for given date range (2025-05-01 to 2025-09-09).

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 Brigitta Sipőcz <bsipocz@gmail.com>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

(I also don't use did any more, fortunately my management stopped requiring such detailed reporting)

[cardil]

@bsipocz You should use did --since 2025-05-01 --github-pull-requests-merged if you want to try #311

BTW. I updated that PR to solve conflicts

[bsipocz]

Indeed that works nicely!