test: cover changes

Author: gm0stache

pkg/client/dns.go

@@ -7,6 +7,7 @@ import (
 	"io"
 	"net"
 	"net/http"
+	"net/netip"
 	"sync"
 	"time"
 
@@ -109,9 +110,7 @@ func verifyCaddyReachable(ctx context.Context, m *pb.MachineInfo) error {
 	eventID := fmt.Sprintf("Machine %s (%s)", m.Name, publicIP)
 	pw.Event(progress.NewEvent(eventID, progress.Working, "Querying"))
 
-	httpFormattedIP := net.JoinHostPort(publicIP.String(), "")
-	verifyURL := fmt.Sprintf("http://%s%s", httpFormattedIP, caddyconfig.VerifyPath)
-
+	verifyURL := getVerifyURL(publicIP)
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, verifyURL, nil)
 	if err != nil {
 		pw.Event(progress.NewEvent(eventID, progress.Error, err.Error()))
@@ -172,6 +171,11 @@ func verifyCaddyReachable(ctx context.Context, m *pb.MachineInfo) error {
 	}
 }
 
+func getVerifyURL(publicIP netip.Addr) string {
+	httpFormattedIP := net.JoinHostPort(publicIP.String(), "")
+	return fmt.Sprintf("http://%s%s", httpFormattedIP, caddyconfig.VerifyPath)
+}
+
 // unreachable creates a new Unreachable error event.
 func unreachable(id string) progress.Event {
 	return progress.NewEvent(

pkg/client/dns_internal_test.go

@@ -0,0 +1,29 @@
+package client
+
+import (
+	"net/netip"
+	"testing"
+)
+
+func TestGetVerifyURL(t *testing.T) {
+	tests := map[string]struct {
+		ip   netip.Addr
+		want string
+	}{
+		"IPv4": {
+			ip:   netip.MustParseAddr("93.184.216.34"),
+			want: "http://93.184.216.34:/.uncloud-verify",
+		},
+		"IPv6": {
+			ip:   netip.MustParseAddr("2001:db8::1"),
+			want: "http://[2001:db8::1]:/.uncloud-verify",
+		},
+	}
+	for name, tt := range tests {
+		t.Run(name, func(t *testing.T) {
+			if got := getVerifyURL(tt.ip); got != tt.want {
+				t.Errorf("getVerifyURL() = %q, want %q", got, tt.want)
+			}
+		})
+	}
+}