Transfers get stuck processing due to wrong node permission check on successful transfer status update

[MrSoulPenguin]

Current Behavior

Currently, the panel attempts to check if the successful transfer status update is coming from the new node by checking if the servers node is the new node in the transfer, before the server has been updated to the new node, always failing.

Expected Behavior

The panel should check if the node making the request is the new node in the transfer.

Steps to Reproduce

Attempt to transfer a server.

Panel Version

1.12.1

Wings Version

1.12.1

Games and/or Eggs Affected

N/A

Docker Image

N/A

Error Logs

ERROR: [...] failed to set transfer status on panel error=Error response from Panel: HttpForbiddenException: Requesting node does not have permission to access this server. (HTTP/403) server=... status=true subsystem=transfer

Is there an existing issue for this?

• I have searched the existing issues before opening this issue. I understand that maintainers may close this issue without communication if I have not provided sufficient information.

[OzanKEreal]

Same error

[clanddora]

It doesn't work for me either.

[ollieread]

I've done a bit of debugging, and the issue with this was introduced in #5476.

Specifically this:

if (! $server->node->is($transfer->newNode)) {
    throw new HttpForbiddenException('Requesting node does not have permission to access this server.');
}

This code is in \Pterodactyl\Http\Controllers\Api\Remote\Servers\ServerTransferController::success, and causes the request to fail because the server's current node isn't the new node it's transferring to. The server is actually assigned to the new node under this, so it's not actually possible for a transfer to be marked as successful.

[MrSoulPenguin]

Yeah, this was outlined in the issue, albeit with worse wording on my part.

There's been a pr open since I submitted my issue resolving what you outlined, another issue with \Pterodactyl\Http\Controllers\Api\Remote\Servers\ServerTransferController::failure checking the nodes against the servers current node instead of the requesting node, and adds tests to catch these in the future.

While don't want to come off as pushy or anything of the sort. I'd be lying if I said I wasn't curious about the delay in this issue getting looked into further (if it hasn't been already behind the scenes). Especially since this issue being encountered does require some manual database and file cleanup.

[ollieread]

Yeah, this was outlined in the issue, albeit with worse wording on my part.

There's been a pr open since I submitted my issue resolving what you outlined, another issue with \Pterodactyl\Http\Controllers\Api\Remote\Servers\ServerTransferController::failure checking the nodes against the servers current node instead of the requesting node, and adds tests to catch these in the future.

While don't want to come off as pushy or anything of the sort. I'd be lying if I said I wasn't curious about the delay in this issue getting looked into further (if it hasn't been already behind the scenes). Especially since this issue being encountered does require some manual database and file cleanup.

Exactly. A gist of mine has been making its way around the discord with the steps to manually rectify the issue. I was tempted to write a script for people to run, but I'd rather not encourage users to run unknown code