Skip to content

Commit 0d7715b

Browse files
committed
remove validateRemoteHybridSettings, no longer needed
1 parent 96052c4 commit 0d7715b

2 files changed

Lines changed: 0 additions & 33 deletions

File tree

clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,6 @@ public void run() {
762762
HadoopUtils.createDirectoryWithPermission(sharedTmpDir, PERMISSION_777);
763763
HadoopUtils.createDirectoryWithPermission(jobTmpDir, PERMISSION_700);
764764
pushJobSetting.newKmeSchemasFromController = validateAndFetchNewKafkaMessageEnvelopeSchemas(pushJobSetting);
765-
validateRemoteHybridSettings(pushJobSetting);
766765
validateStoreSettingAndPopulate(controllerClient, pushJobSetting);
767766
inputStorageQuotaTracker = new InputStorageQuotaTracker(pushJobSetting.storeStorageQuota);
768767

@@ -2031,15 +2030,6 @@ void validateKeySchema(PushJobSetting setting) {
20312030
}
20322031
}
20332032

2034-
protected void validateRemoteHybridSettings() {
2035-
validateRemoteHybridSettings(pushJobSetting);
2036-
}
2037-
2038-
protected void validateRemoteHybridSettings(PushJobSetting setting) {
2039-
// No-op: With epoch passthrough, the absolute epoch timestamp flows directly through the
2040-
// pipeline, making the SOP/EOP replay policy validation unnecessary.
2041-
}
2042-
20432033
private Map<Integer, String> validateAndFetchNewKafkaMessageEnvelopeSchemas(PushJobSetting setting) {
20442034
// Obtain the highest schema for KME from controller
20452035
int localHighestKmeSchemaId = AvroProtocolDefinition.KAFKA_MESSAGE_ENVELOPE.getCurrentProtocolVersion();

clients/venice-push-job/src/test/java/com/linkedin/venice/hadoop/TestKafkaFormatTopicAutoDiscover.java

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import static com.linkedin.venice.vpj.VenicePushJobConstants.D2_ZK_HOSTS_PREFIX;
55
import static com.linkedin.venice.vpj.VenicePushJobConstants.KAFKA_INPUT_BROKER_URL;
66
import static com.linkedin.venice.vpj.VenicePushJobConstants.KAFKA_INPUT_TOPIC;
7-
import static com.linkedin.venice.vpj.VenicePushJobConstants.REWIND_EPOCH_TIME_IN_SECONDS_OVERRIDE;
87
import static com.linkedin.venice.vpj.VenicePushJobConstants.SOURCE_GRID_FABRIC;
98
import static com.linkedin.venice.vpj.VenicePushJobConstants.SOURCE_KAFKA;
109
import static com.linkedin.venice.vpj.VenicePushJobConstants.SSL_KEY_PASSWORD_PROPERTY_NAME;
@@ -65,28 +64,6 @@ public void testNoUserProvidedTopicNameAndSingleColoVersion() {
6564
}
6665
}
6766

68-
@Test
69-
public void testUserProvidedEpochRewind() {
70-
final int singleColoCurrentVersion = 1;
71-
ControllerClient controllerClient = mock(ControllerClient.class);
72-
Map<String, Integer> coloToVersionMap = Collections.emptyMap();
73-
StoreResponse storeResponse =
74-
getMockHybridStoreResponse(coloToVersionMap, singleColoCurrentVersion, BufferReplayPolicy.REWIND_FROM_SOP);
75-
when(controllerClient.getStore(STORE_NAME)).thenReturn(storeResponse);
76-
RepushInfoResponse repushInfo = getMockRepushResponse(1);
77-
when(controllerClient.getRepushInfo(STORE_NAME, Optional.empty())).thenReturn(repushInfo);
78-
configureClusterDiscoveryControllerClient(controllerClient);
79-
Map<String, String> overrideProperties = new HashMap<>();
80-
overrideProperties.put(VENICE_STORE_NAME_PROP, STORE_NAME);
81-
overrideProperties.put(REWIND_EPOCH_TIME_IN_SECONDS_OVERRIDE, "1637016606");
82-
try (VenicePushJob venicePushJob = new VenicePushJob(JOB_ID, getJobProperties(overrideProperties))) {
83-
venicePushJob.setControllerClient(controllerClient);
84-
venicePushJob.initKIFRepushDetails();
85-
venicePushJob.setControllerClient(controllerClient);
86-
venicePushJob.validateRemoteHybridSettings();
87-
}
88-
}
89-
9067
@Test
9168
public void testNoUserProvidedTopicNameAndMultiColoVersion() {
9269
final int multipleColoCurrentVersion = 1;

0 commit comments

Comments
 (0)