Skip to content

Commit 13f72e1

Browse files
pthirunclaude
andcommitted
[vpj] Remove dead validateRemoteReplayPolicy field to fix SpotBugs
The SOP-only restriction was removed as part of epoch passthrough, but the validateRemoteReplayPolicy field and its usage were left behind. SpotBugs flagged the field as never written. Remove the dead field and make validateRemoteHybridSettings a no-op. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0e23010 commit 13f72e1

2 files changed

Lines changed: 3 additions & 14 deletions

File tree

clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/PushJobSetting.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.linkedin.venice.controllerapi.StoreResponse;
66
import com.linkedin.venice.etl.ETLValueSchemaTransformation;
77
import com.linkedin.venice.jobs.DataWriterComputeJob;
8-
import com.linkedin.venice.meta.BufferReplayPolicy;
98
import com.linkedin.venice.meta.HybridStoreConfig;
109
import com.linkedin.venice.meta.Version;
1110
import com.linkedin.venice.schema.vson.VsonSchema;
@@ -57,7 +56,7 @@ public class PushJobSetting implements Serializable {
5756
public boolean pushToSeparateRealtimeTopicEnabled;
5857
public boolean kafkaInputCombinerEnabled;
5958
public boolean kafkaInputBuildNewDictEnabled;
60-
public BufferReplayPolicy validateRemoteReplayPolicy;
59+
6160
public boolean suppressEndOfPushMessage;
6261
public boolean deferVersionSwap;
6362
public boolean extendedSchemaValidityCheckEnabled;

clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1987,18 +1987,8 @@ protected void validateRemoteHybridSettings() {
19871987
}
19881988

19891989
protected void validateRemoteHybridSettings(PushJobSetting setting) {
1990-
if (setting.validateRemoteReplayPolicy != null) {
1991-
StoreResponse response = getStoreResponse(setting.storeName);
1992-
HybridStoreConfig hybridStoreConfig = response.getStore().getHybridStoreConfig();
1993-
if (!setting.validateRemoteReplayPolicy.equals(hybridStoreConfig.getBufferReplayPolicy())) {
1994-
throw new VeniceException(
1995-
String.format(
1996-
"Remote rewind policy is %s but push settings require a policy of %s. "
1997-
+ "Please adjust hybrid settings or push job configuration!",
1998-
hybridStoreConfig.getBufferReplayPolicy(),
1999-
setting.validateRemoteReplayPolicy));
2000-
}
2001-
}
1990+
// No-op: With epoch passthrough, the absolute epoch timestamp flows directly through the
1991+
// pipeline, making the SOP/EOP replay policy validation unnecessary.
20021992
}
20031993

20041994
private Map<Integer, String> validateAndFetchNewKafkaMessageEnvelopeSchemas(PushJobSetting setting) {

0 commit comments

Comments
 (0)