Skip to content

Commit 240ae50

Browse files
pthirunclaude
andcommitted
Fix StoresRoutesTest to pass StoreRequestHandler to constructor
The getRepushInfo route uses storeRequestHandler from the class field, so tests need to pass the mocked handler to the StoresRoutes constructor. Fixed both testGetRepushInfo and testGetRepushInfoWithoutFabric tests. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 8e4241b commit 240ae50

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

services/venice-controller/src/test/java/com/linkedin/venice/controller/server/StoresRoutesTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,8 @@ public void testGetRepushInfo() throws Exception {
704704
doReturn(queryMap).when(queryParamsMap).toMap();
705705
doReturn(queryParamsMap).when(request).queryMap();
706706

707-
Route route = new StoresRoutes(false, Optional.empty(), pubSubTopicRepository).getRepushInfo(mockAdmin);
707+
Route route =
708+
new StoresRoutes(false, Optional.empty(), pubSubTopicRepository, mockRequestHandler).getRepushInfo(mockAdmin);
708709

709710
// Create a real Version for admin.getRepushInfo() call to avoid Jackson serialization issues
710711
Version version = new VersionImpl(TEST_STORE_NAME, 1, "test-push-job", 10);
@@ -755,7 +756,8 @@ public void testGetRepushInfoWithoutFabric() throws Exception {
755756
doReturn(queryMap).when(queryParamsMap).toMap();
756757
doReturn(queryParamsMap).when(request).queryMap();
757758

758-
Route route = new StoresRoutes(false, Optional.empty(), pubSubTopicRepository).getRepushInfo(mockAdmin);
759+
Route route =
760+
new StoresRoutes(false, Optional.empty(), pubSubTopicRepository, mockRequestHandler).getRepushInfo(mockAdmin);
759761

760762
RepushInfo mockRepushInfo = RepushInfo.createRepushInfo(null, "another.kafka:9092", null, null);
761763

0 commit comments

Comments
 (0)